Feature/build fix#71
Conversation
|
Fixes #72 build-rgbds-live fails because my bad commit last time |
SelvinPL
force-pushed
the
feature/build_fix
branch
2 times, most recently
from
00bf48e to
214bf92
Compare
|
explenation of force pushes: |
| - main | ||
| pull_request: | ||
|
|
||
| env: |
There was a problem hiding this comment.
copy from rgbds-live instead installing with
mkdir $HOME/emsdk
git clone --depth 1 https://github.com/emscripten-core/emsdk.git $HOME/emsdk
$HOME/emsdk/emsdk update-tags
$HOME/emsdk/emsdk install tot
$HOME/emsdk/emsdk activate tot
we can use mymindstorm/setup-emsdk@v14 ... it will setup the path ans stuff
|
|
||
| - name: cmake | ||
| run: cmake -S . -B out -G Ninja -DCMAKE_TOOLCHAIN_FILE=$HOME/emsdk/upstream/emscripten/cmake/Modules/Platform/Emscripten.cmake -DCMAKE_BUILD_TYPE=Release -DWASM=true | ||
| run: emcmake cmake -S . -B out -G Ninja -DCMAKE_BUILD_TYPE=Release -DWASM=true |
There was a problem hiding this comment.
using emcmake will add toolchain
| run: | | ||
| source $HOME/emsdk/emsdk_env.sh | ||
| cmake --build out | ||
| run: emmake cmake --build out |
There was a problem hiding this comment.
with mymindstorm/setup-emsdk@v14 there is no need for "source ..."
|
|
||
| - name: update path | ||
| run: echo "PATH=$PATH:$HOME/emsdk" >> $GITHUB_ENV | ||
| build-rgbds-live: |
There was a problem hiding this comment.
it just a copy of wasm build but with rgbds-live specific flags
| Run('nmake', cwd=WLA_DX_BUILD_DIR) | ||
| else: | ||
| Run('cmake', WLA_DX_DIR, cwd=WLA_DX_BUILD_DIR) | ||
| Run('cmake', '-DCMAKE_POLICY_VERSION_MINIMUM=3.5', '-DCMAKE_C_FLAGS=-Wno-strict-prototypes', WLA_DX_DIR, cwd=WLA_DX_BUILD_DIR) |
There was a problem hiding this comment.
WLA_DX is using cmake minimum veriosn 2.8 or somethig ... also without no-strict-prototypes build fails
SelvinPL
force-pushed
the
feature/build_fix
branch
from
c00106c to
599e83e
Compare
|
last force push is after rebasing to new main commits |
|
and now ...it passes all builds finally |
2 participants
No description provided.