Fix Selects (for real)#157
Open
geoffrey-eisenbarth wants to merge 3 commits intobigskysoftware:devfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This aims to finish what was started in #50, #91, #140, #139, and most recently #152. While it seems like a lot, it doesn't actually introduce any breaking changes, and really is just a bug fix with an eye for the future.
Please review the docs carefully and play around with all the different select options.
It's worth noting that to inspect the customizable selects and mess around with variables, you might need to use Canary since Chrome 145 DevTools has a bug that vomits due tolight-dark(var(--one), var(--two)).EDIT: Actually, as I was checking my version of Chrome, it updated to
146.0.7680.72and the issue seems fixed!EDIT 2: The Editing: Maybe Chrome DevTools is still broken. Canary works.
Consider giving some consideration to:
outline-offset: -2px?optgroup > optionpadding: I use the standardcalc(var(--rhythm, 1rlh) / 4) == .25rlhfor padding, and then indent to1em(setting--indent: calc(var(--rhythm, 1rlh) / 2)didn't seem like enough?(min-?)inline-size: 23ch. Not sure what would be best. Also whatever pseudo tables does doesn't seem to effect the widths of these. You can see in the six listboxes examples that they are sized slightly different bc of icons, they don't take up the full width, etc. This might need some nuance?I think there's probably something I can do to clean up the visibility and display values of
::checkmark. Perhaps it's best discussed in person.I think this is the last big thing for 1.2.1! 🎉