Allows hx-live to cache JS eval functions#3919
Open
MichaelWest22 wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I found that we can get around a 23x speed improvment to hx-live expression evaluations by updating executeJavaScript function to return a function instead of the value which then allows hx-live to cache this function in its run closure
Corresponding issue:
Testing
Tested performance and found it went from around 1.15s for 20,000 live bindings to 50ms. No real function changes so tests all pass.
Checklist
masterfor website changes,devforsource changes)
approved via an issue
npm run test) and verified that it succeeded