Respect disabled history during swaps#3913
Open
scriptogre wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When
htmx.config.historyisfalse, swaps still emit history update events around a no-op URL update. The history cache extension handles those events and saves the outgoing page despite history being disabled.Return before resolving or emitting a history update when history is disabled.
Corresponding issue: none
Testing
Added an integration test that performs an
hx-push-urlrequest with history disabled and verifies the history cache stays empty.Chromium: 1,588 passed, 0 failed, 6 skipped.
Checklist
four-dev)