update hx-live to use xpath and handle alpine conflict#3820
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
hx-live should use xpath for more efficient scanning of hx-live:* attributes as it currently does inefficient full scans.
Also need to address the alpine compatibility issue. Alpine uses the same :attr form as the proposed hx-live parsing and if they are both enabled then they both try and register the same behavior and the different syntaxes causes errors. While we could move to a safer default short bind form like live:attr or hx:attr or _attr none of them are as nice and well understood as the alpine pattern. So to avoid conflicts we could detect alpine and disable the default : short form prefix and post a warning to the console so users can opt in or out of the short form or pick an alternative short form.
Corresponding issue:
Testing
Please explain how you tested this change manually, and, if applicable, what new tests you added. If
you're making a change to just the website, you can omit this section.
Checklist
masterfor website changes,devforsource changes)
approved via an issue
npm run test) and verified that it succeeded