Skip to content

fixed syntax error in code example#635

Merged
1cg merged 1 commit intobigskysoftware:masterfrom
esmiralha:master
Mar 13, 2026
Merged

fixed syntax error in code example#635
1cg merged 1 commit intobigskysoftware:masterfrom
esmiralha:master

Conversation

@esmiralha
Copy link
Copy Markdown
Contributor

fixed a typo in a code example for the toggle command

@zyriab
Copy link
Copy Markdown
Contributor

zyriab commented Jul 31, 2025

This is not a typo, see this test.
You toggle X on Y. *display is not owned by the next <div/>, it's a class that you toggle (add/remove) on it.

Hope that made sense 😄

@esmiralha
Copy link
Copy Markdown
Contributor Author

This is not a typo, see this test.
You toggle X on Y. *display is not owned by the next <div/>, it's a class that you toggle (add/remove) on it.

Hope that made sense 😄

I might be at fault here, but I couldn't make the example work as it is in the docs. I had to change "on" to "of" to make it work for *display.

@esmiralha
Copy link
Copy Markdown
Contributor Author

If you look at line 161 of the test it uses "of" instead of "on".

@zyriab
Copy link
Copy Markdown
Contributor

zyriab commented Aug 3, 2025

Oh interesting!

@geoffrey-eisenbarth
Copy link
Copy Markdown
Contributor

geoffrey-eisenbarth commented Aug 3, 2025

@zyriab The docs specifically mention using of for toggling *opacity

toggle [the | my] ('*opacity' | '*visibility' | '*display')
 [of <expression>]
  [(for <time expression>) |
   (until <event name> [from <expression>]]`

@esmiralha
Copy link
Copy Markdown
Contributor Author

yup but the code example at the bottom of the page uses on.

@1cg 1cg merged commit 3f66035 into bigskysoftware:master Mar 13, 2026
4 checks passed
@1cg
Copy link
Copy Markdown
Contributor

1cg commented Mar 13, 2026

Thank you!

1cg pushed a commit that referenced this pull request Mar 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants