Skip to content

LTRAC-991: Remove custom domain command#3073

Open
jorgemoya wants to merge 6 commits into
alphafrom
jorgemoya/ltrac-991-cli-remove-custom-domain-command
Open

LTRAC-991: Remove custom domain command#3073
jorgemoya wants to merge 6 commits into
alphafrom
jorgemoya/ltrac-991-cli-remove-custom-domain-command

Conversation

@jorgemoya

Copy link
Copy Markdown
Contributor

What/Why?

Refs LTRAC-991

Adds catalyst domains remove <domain> on top of the stacked domain command work. The command fetches the current domain status before deleting, prompts before removing an active domain, supports --force to skip the prompt, and calls the Native Hosting domain delete endpoint.

This PR is stacked after #3072 and should be reviewed/merged after that PR.

Testing

  • node_modules/.bin/vitest run src/cli/commands/domains.spec.ts
  • node_modules/.bin/tsc --noEmit
  • node_modules/.bin/eslint src/cli/commands/domains.ts src/cli/commands/domains.spec.ts src/cli/lib/domains.ts tests/mocks/handlers.ts --max-warnings 0

Full node_modules/.bin/vitest run --coverage was attempted on #3070, but this local environment fails unrelated existing tests that require api.github.com network access and npm package env vars.

Migration

None.

Add a domains command group with a create-domain API client and wait support for pending domain verification.

Refs LTRAC-988
@vercel

vercel Bot commented Jun 29, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
catalyst Ready Ready Preview, Comment Jun 29, 2026 8:04pm

Request Review

@github-actions

Copy link
Copy Markdown
Contributor

Bundle Size Report

Comparing against baseline from 81b88df (2026-06-29).

No bundle size changes detected.

Include the HTTP status and correlation ID when domain API requests fail with a server-side response so 502 Bad Gateway errors are actionable.

Refs LTRAC-988
Keep domain API server error messages concise because the CLI fatal error handler already prints the correlation ID for support.

Refs LTRAC-988
Add domain listing support with optional domain and verification-status filters so users can scan configured Native Hosting domains from the CLI.

Refs LTRAC-989
Add a domains status command that fetches one domain, renders its color-coded state, and can wait for pending verification to finish.

Refs LTRAC-990
Add a domains remove command that checks current status, confirms active domain removal, and deletes the domain through the Native Hosting API.

Refs LTRAC-991
@jorgemoya jorgemoya force-pushed the jorgemoya/ltrac-991-cli-remove-custom-domain-command branch from 9418037 to 8b5053c Compare June 29, 2026 20:03
@changeset-bot

changeset-bot Bot commented Jun 29, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 8b5053c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@jorgemoya

jorgemoya commented Jun 29, 2026

Copy link
Copy Markdown
Contributor Author

Tested locally:

~/dev/catalyst/core on  jorgemoya/ltrac-991-cli-remove-custom-domain-command [✘!?]
❯ node ../packages/catalyst/dist/cli.js domains remove www.jorgemoya.dev --api-host api.staging.zone
◢ @bigcommerce/catalyst v1.0.0-alpha.6                                                                                                                   4:02:36 PM

◐ Fetching status for www.jorgemoya.dev...                                                                                                               4:02:36 PM
✔ Remove active domain www.jorgemoya.dev? Traffic may stop routing to this project. Yes
◐ Removing domain www.jorgemoya.dev...                                                                                                                   4:02:41 PM
✔ Domain www.jorgemoya.dev removed.           

~/dev/catalyst/core on  jorgemoya/ltrac-991-cli-remove-custom-domain-command [✘!?] took 2s
❯ node ../packages/catalyst/dist/cli.js domains list  --api-host api.staging.zone
◢ @bigcommerce/catalyst v1.0.0-alpha.6                                                                                                                   3:42:59 PM

◐ Fetching domains...                                                                                                                                    3:42:59 PM
✔ Domains fetched.                                                                                                                                      3:42:59 PM
jm-staging-test-v2.catalyst-sandbox-staging.store active         

@github-actions

Copy link
Copy Markdown
Contributor

Unlighthouse Performance Comparison — Vercel

Comparing PR preview deployment Unlighthouse scores vs production Unlighthouse scores.

Summary Score

Aggregate score across all categories as reported by Unlighthouse.

Prod Desktop Prod Mobile Preview Desktop Preview Mobile
Score 90 92 92 95

Category Scores

Category Prod Desktop Prod Mobile Preview Desktop Preview Mobile
Performance 76 79 73 79
Accessibility 95 98 95 98
Best Practices 100 100 100 100
SEO 88 88 88 100

Core Web Vitals

Metric Prod Desktop Prod Mobile Preview Desktop Preview Mobile
LCP 3.7 s 3.9 s 3.9 s 5.6 s
CLS 0.001 0.183 0.037 0
FCP 1.2 s 1.2 s 1.2 s 1.2 s
TBT 0 ms 10 ms 20 ms 10 ms
Max Potential FID 40 ms 60 ms 70 ms 60 ms
Time to Interactive 3.7 s 4.0 s 4.6 s 5.8 s

Full Unlighthouse report →

@jorgemoya jorgemoya marked this pull request as ready for review June 29, 2026 21:29
@jorgemoya jorgemoya requested a review from a team as a code owner June 29, 2026 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant