Skip to content

Add optional LDAP and Active Directory authentication - #106

Merged
bifrost0x merged 6 commits into
mainfrom
dev/ldap-authentication
Aug 14, 2026
Merged

Add optional LDAP and Active Directory authentication#106
bifrost0x merged 6 commits into
mainfrom
dev/ldap-authentication

Conversation

@bifrost0x

Copy link
Copy Markdown
Owner

Summary

  • add optional LDAP and Active Directory authentication, disabled by default
  • require explicit identity linking to an existing WebSSH account; no automatic provisioning or privilege mapping
  • support certificate-verified StartTLS and LDAPS with bounded connection and operation timeouts
  • keep bind credentials and the trusted CA bundle in a read-only runtime secret volume
  • provide a dedicated Compose overlay, isolated secret helper, operator documentation, and a disposable OpenLDAP integration lab
  • revalidate LDAP-managed sessions and preserve audit logging, rate limits, CSRF protection, and existing local account isolation
  • present LDAP sign-in as an exclusive login mode with a clear back action instead of expanding it below other authentication methods

Deployment behavior

  • the base Compose deployment does not start or mount LDAP infrastructure
  • LDAP is enabled only through docker-compose.ldap.yml and complete operator-supplied settings
  • the ldap-tools helper runs only when explicitly invoked through its profile
  • disabled installations retain the existing login flow and do not load LDAP routes or background work

Verification

  • 1,554 Python tests passed, 33 skipped
  • 200 JavaScript unit tests passed
  • 66 Playwright E2E tests passed
  • vendored frontend integrity check passed
  • JavaScript lint passed
  • dependency lock check passed
  • base, LDAP overlay, helper-profile, and production Compose resolution passed
  • disposable StartTLS lab reported healthy readiness and completed a real linked-user login
  • LDAP/default mode switching and the failed-login isolated state were verified in the live browser UI

Comment thread tests/test_production_config.py Fixed
Comment thread tests/test_production_config.py Fixed
@bifrost0x
bifrost0x marked this pull request as ready for review August 14, 2026 08:19
@bifrost0x bifrost0x self-assigned this Aug 14, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f050d58707

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread app/ldap_routes.py
Comment thread config.py Outdated
@bifrost0x
bifrost0x merged commit 9bd9b2a into main Aug 14, 2026
15 of 16 checks passed
@bifrost0x
bifrost0x deleted the dev/ldap-authentication branch August 14, 2026 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants