Fix watched video sync when using browser back button#11
Open
rm335 wants to merge 1 commit intobierteam:masterfrom
Open
Fix watched video sync when using browser back button#11rm335 wants to merge 1 commit intobierteam:masterfrom
rm335 wants to merge 1 commit intobierteam:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pagehide,pageshow,popstate, andvisibilitychangeevent listeners to cover bfcache and SPA navigation scenarios wherebeforeunloaddoes not fireProblem
The extension relied on
beforeunloadandclickevents to sync viewed items betweensessionStorageandlocalStorage. Modern browsers use the back-forward cache (bfcache), which suppressesbeforeunload. Additionally, Dumpert's new SPA UI uses the History API for navigation, triggeringpopstateinstead of a page unload. This meant watched video state was lost when using the back button.Solution
Added four additional event listeners:
pagehidebeforeunload)pageshowpopstatevisibilitychangeTest plan