Add desktop back and forward navigation#154
Conversation
Co-Authored-By: Oz <oz-agent@warp.dev>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Tested this locally against my linked Markdown workspace. The navigation behavior works well, including Back/Forward through linked notes. I did find a macOS layout issue when the sidebar is open: the navigation buttons remain close to and occasionally overlaps with the window traffic lights instead of aligning with the right side of the sidebar header. I believe this is because ToolbarActions reads --sidebar-width, but that custom property is defined on the Sidebar element. Since the Toolbar and Sidebar are siblings in App.tsx, the Toolbar cannot inherit it and falls back to 114px. A possible fix would be to expose the sidebar width on their shared parent or pass the width into the Toolbar directly. That should keep the navigation controls aligned near the sidebar’s right edge at every sidebar width while preserving the traffic-light safe area when the sidebar is closed. The underlying feature otherwise checks out in my workflow. Happy to test an adjustment or contribute the small layout fix if helpful. |
Closes #111
Summary
CmdOrCtrl+[/CmdOrCtrl+]shortcut hints and matching keyboard handling.Validation
pnpm check✅pnpm --filter @hubble.md/editor build && pnpm --filter @hubble.md/ui build && pnpm --filter @hubble.md/desktop test -- src/store/actions.test.ts✅pnpm build:desktop✅.agents/skills/test-desktop-app/SKILL.md✅HUBBLE_DESKTOP_ENABLE_CDP=1 xvfb-run -a pnpm --dir apps/desktop dev -- --no-sandbox.project-ideas.md→README.md, verified Back/Forward enablement, navigated withCtrl+[andCtrl+], then navigated with the toolbar Back/Forward buttons.Notes
xvfb-runand--no-sandboxin this Linux sandbox; the app was stopped afterward and no Electron dev process remained.Conversation: https://app.warp.dev/conversation/a90cd638-d897-4e0a-8a20-4ade3cf524a8
Run: https://oz.warp.dev/runs/019f4751-49b3-707f-9e17-7f88602923bf
This PR was generated with Oz.