fix(deps): swap aws-sdk-s3 off rustls 0.21 (legacy) onto rustls 0.23+#4
Merged
Conversation
The two RUSTSEC advisories cargo-deny just surfaced (RUSTSEC-2026-0099 name-constraint bug, RUSTSEC-2026-0104 CRL panic) both live in rustls-webpki 0.101.7. That version was pinned by rustls 0.21 which itself was pulled in by aws-sdk-s3's `rustls` feature → expands to aws-smithy-http-client/legacy-rustls-ring → rustls 0.21 + hyper 0.14 + hyper-rustls 0.24 + tokio-rustls 0.24, all of which are the deprecated "legacy" client stack maintained alongside the modern one. The same SDK ships `default-https-client` as the modern path, which routes through aws-smithy-http-client/rustls-aws-lc and lands on rustls 0.23 + rustls-webpki 0.103. Switching to that feature for both aws-config and aws-sdk-s3, plus dropping the unused `connector-hyper-0-14-x` feature from aws-smithy-runtime, removes the entire legacy stack from Cargo.lock. Verified the s3 integration suite still passes locally (15/15) — the SDK now uses the modern HTTPS client by default and the tests, which only hit plain HTTP, are agnostic to the change. Remaining cargo-deny noise: two upstream "unmaintained" notices (atomic-polyfill via beyond-handoff, rustls-pemfile via the AWS SDK). Both transitive, no CVE, no safe upgrade until the upstream chains move. Suppressed in deny.toml with linked reasons so the next genuine regression on either crate still trips the check. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Eliminates the two RUSTSEC advisories the new `cargo-deny` workflow surfaced (both in `rustls-webpki 0.101.7`, pinned by `rustls 0.21`):
These were reached via aws-sdk-s3's `rustls` feature → `aws-smithy-http-client/legacy-rustls-ring` (the deprecated legacy client stack). The SDK ships `default-https-client` as the modern path, which routes through `aws-smithy-http-client/rustls-aws-lc` and lands on `rustls 0.23` + `rustls-webpki 0.103`.
Swap dev-deps to the modern feature, drop the unused `connector-hyper-0-14-x`. `Cargo.lock` loses the entire legacy stack:
```
Removing h2 0.3.27, hyper 0.14.32, hyper-rustls 0.24.2,
rustls 0.21.12, rustls-webpki 0.101.7, sct 0.7.1,
tokio-rustls 0.24.1
```
Plus two upstream "unmaintained" notices suppressed in `deny.toml` with linked reasons:
Test plan
🤖 Generated with Claude Code