Conversation
mKnoop
left a comment
There was a problem hiding this comment.
Nice Idea. But i think we should also consider the cache hash keys for the expiration time and not set the value for all entries once
@mKnoop What is your reasoning behind this? |
The implementation in this pr will set a global expiration time if a new cache entry will be written. If later in the process we want to refetch a existing item from the cache the expiration time from the last new entry will be used instead of the expiration time of the specific entry. So in my opinion the expiration time should be item specific and the optimal workflow should be: Existing entry:
new entry:
I think this should cover the initial proposal that in long running processes the memory cache value will also be refreshed after the expiration time |
If cache ttl times out while php worker executing, it would be great to update feature flag value.