Add support for Guzzle 8#1111
Open
GrahamCampbell wants to merge 1 commit into
Open
Conversation
Member
|
PR 1111, nice! Thank you for your work - I'm keeping track of the PRs in the other repos and will enable the workflows once they're all ready.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds Guzzle 8 support by widening the
guzzlehttp/guzzle,guzzlehttp/psr7andguzzlehttp/promisesconstraints to allow their new majors alongside the current ones. Guzzle 8 removedgetResponse()from the baseRequestException, where it now lives only on theResponseExceptionsubclasses, and reclassified connection failures underPsr\Http\Client\NetworkExceptionInterface. The five API exception converters therefore guard the response lookup so it resolves on both majors, and the Remote Config converter catches the PSR-18 network interface for connection errors. The behaviour is unchanged on Guzzle 7.Composer can only resolve Guzzle 8 here once this project's own dependencies allow it, so this PR depends on releases from beste/firebase-tokens-php#73 (
kreait/firebase-tokens), googleapis/google-auth-library-php#677 (google/auth) and googleapis/google-cloud-php#9377 (google/cloud-storage). Until those ship, Composer keeps resolving Guzzle 7 and this branch stays fully compatible with it.