Expose PuppeteerExtraPluginRecaptcha error#741
Open
markcellus wants to merge 1 commit intoberstend:masterfrom
Open
Expose PuppeteerExtraPluginRecaptcha error#741markcellus wants to merge 1 commit intoberstend:masterfrom
PuppeteerExtraPluginRecaptcha error#741markcellus wants to merge 1 commit intoberstend:masterfrom
Conversation
c5df644 to
e5e94be
Compare
e5e94be to
f351109
Compare
Author
|
Perhaps a better way to do this is to create a new error class that extends |
PuppeteerExtraPluginRecaptcha error
Owner
|
Yeah, the error handling isn't optimal 😄 I wonder if this would work as a fix as well: if (this.opts.throwOnError && response.error) {
throw !!response.error?.message ? response.error : new Error(response.error)
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #740 by updating the
PuppeteerExtraPluginRecaptchathrown error and exposes all of its properties to be evaluated by consumer code.