Extract Assignment Due Date Logic to AssignmentDateCalculator Service Object#293
Conversation
Remove unused `calculate_new_assignment_dates` and `calculate_new_late_due_date` methods from Request model along with their duplicate integration tests. Remove tests that tried to set `extend_late_due_date` to nil, which is no longer possible after the NOT NULL migration. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
things don't seem to be quite right.
if the assignment contains no late due date then none should be set on the external service regardless of the course settings.
It may be more clear if the facades can accept a nil value and not force it be present, but the facade is always called with the exact right arguments.
Please extract the due date logic into a new service object, AssignmentDateCalculator
This new class should take in 3 things: assignment, request, course settings
It should then output:
release_date, due_date, late_due_date
for now release date should always be nil.
Include and refactor tests
Superconductor Ticket Implementation | App Preview