Add Windows fixes so abc compiles natively with GCC.#435
Conversation
Hi, I'm not on windows but have you tried |
No, I didn't bisect because there isn't a single commit that corresponds to the issues this PR fixes. Additionally, the 32768 character problem is just going to keep coming back, now that the link command is approximately large enough. |
|
I updated this for latest |
|
@wjrforcyber This PR has been rebased and should be ready for merging. |
Hi! Thanks for letting me know. However, I'm just a contributor, not a collaborator, so I don't have the permission to select or merge PRs. You need to let @alanminko know and he'll review and decide. 😊 |
This PR fixes some Windows compilation issues I found when compiling with GCC on Windows (MinGW64/MSYS2 specifically in my case):
Turns someFixed upstream in the meantime.WIN32checks into more-accurate MSVC-specific checks using_MSC_VERvariable. These should not affect compilation with MSVC.-lrtfrom the linked libraries (doesn't really exist for Windows, AFAIR), and add the-lshlwapilibrary becauseabcusesPathMatchSpecAsomehow.filefunction for this; the docs even state that response files are an intended usage :D.uname -sisn't necessarily static (it appends a version string, which can vary between systems). I bring in code fromyosysto make theOSvariable remain the same between systems.I mainly follow the
yosysbranch of ABC, so I was able to compileabcwithout issue until a recent merge. By looking at the yosys branch and main side-by-side (git log --all --decorate --oneline --graph), it seems all the commits that required me to make these changes were between 68c576c and now (9c41da6).