Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
Updates the MONet data parsing logic to handle the new "array of Entity" data format instead of the previous "array of thingies" format, fixing the broken map web page functionality.
- Changed coordinate extraction to use the
coordinatesproperty from each entity object - Updated identifier and URL extraction to use standardized
idanduriproperties from entity objects - Modified comment to reflect the new BERtron entity-based data structure
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, on the
mainbranch, the map web page is not loading (screenshot in #111). That's because the data it is fetching is in a different format than the web page was written to parse (the data is in the new "array ofEntitys" format, whereas the web page was written to parse the "array of thingies" format the BERtron hackathon members had come up with a few months ago).On this branch, I updated the web page to parse that data in a way that works with the new format. I expect to do something similar for the other "data sources" (e.g. NMDC, JGI) once their JSON files get updated.
Fixes #111