Skip to content

Audit MPEG-4 box types #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
benrr101 merged 5 commits into from
Apr 11, 2026
Merged

Audit MPEG-4 box types #125

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
70eb13f
Auditing mpeg4 box types
benrr101 Apr 2, 2026
6f2d497
An letter
benrr101 Apr 3, 2026
929067c
Backwards compat and more tests
benrr101 Apr 4, 2026
1bd20dd
Clear existing boxes for conductor/subtitle
benrr101 Apr 11, 2026
a9c5582
Accidentally a ;
benrr101 Apr 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 20 additions & 8 deletions src/mpeg4/mpeg4BoxType.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,11 @@
import {ByteVector, StringType} from "../byteVector";

/**
* Provides references to different box types used by the library. This class is used to severely reduce the number
* of times these types are created in {@link AppleTag,} greatly improving the speed at which warm files are read.
* Provides references to different box types used by the library. This class is used to severely
* reduce the number of times these types are created in {@link AppleTag,} greatly improving the
Comment thread
benrr101 marked this conversation as resolved.
* speed at which warm files are read.
*
* These box types were cross-referenced with FFMPEG source and Exiftool database.
*/
export default class Mpeg4BoxType {
/** QuickTime album artist box */
Expand All @@ -13,8 +16,11 @@ export default class Mpeg4BoxType {
public static readonly ART = this.getType("©ART");
/** QuickTime comment box */
public static readonly CMT = this.getType("©cmt");
/** QuickTime conductor box? @TODO: Verify this works should not be ©con */
public static readonly COND = this.getType("cond");
/**
* QuickTime conductor box
* @remarks "cond" in .NET source, but Exiftool says should be ©con.
*/
public static readonly COND = this.getType("©con");
Comment thread
benrr101 marked this conversation as resolved.
Outdated
/** QuickTime cover art box */
public static readonly COVR = this.getType("covr");
/** ISO 64-bit chunk offset box */
Expand Down Expand Up @@ -91,19 +97,25 @@ export default class Mpeg4BoxType {
public static readonly STCO = this.getType("stco");
/** ISO sample description box */
public static readonly STSD = this.getType("stsd");
/** Subtitle box? @TODO: There's no record of this one */
public static readonly SUBT = this.getType("Subt");
/**
* QuickTime subtitle box
* @remarks "Subt" in .NET source, but this appears to be for subtitle tracks, not metadata.
*/
public static readonly SUBT = this.getType("©st3");
Comment thread
benrr101 marked this conversation as resolved.
Outdated
Comment thread
benrr101 marked this conversation as resolved.
Outdated
/** Alias text box? @TODO: There's no record of this one */
public static readonly TEXT = this.getType("text");
/** QuickTime BPM box */
public static readonly TMPO = this.getType("tmpo");
/** ISO track container box */
public static readonly TRAK = this.getType("trak");
/** QuickTime track number box */
/** QuickTime track number box @TODO: What about ©TRK as per FFMPEG source? */
public static readonly TRKN = this.getType("trkn");
/** ISO User data box */
public static readonly UDTA = this.getType("udta");
/** Alias URL box? @TODO: There's no record of this one */
/**
* Alias URL box?
* @remarks Specified in FFMPEG source but not in Exiftool.
*/
public static readonly URL = this.getType("©url");
/** ISO user extension box */
public static readonly UUID = this.getType("uuid");
Expand Down