fix: force connection close for 204/304 responses (#434) #815
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per RFC 7230 Section 3.3.3, responses with status codes 204 (No Content) and 304 (Not Modified) MUST NOT contain a message body, regardless of any Content-Length or Transfer-Encoding headers. If a misbehaving server sends such headers, reading the body could leave bytes in the socket that corrupt subsequent requests on a reused connection. This fix forces connection close after 204/304 responses to prevent any potential corruption from protocol-violating servers. This matches the approach taken by other HTTP clients like httpx (Python). Fixes #434
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #434