feat: native metrics with Prometheus support (#772, #560) #814
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benoitc
force-pushed
the
feat/772-prometheus-metrics
branch
3 times, most recently
from
5ff03df to
8d375cf
Compare
Replace external metrics library with hackney-native metrics abstraction: - Add hackney_metrics_backend behaviour for pluggable backends - Add hackney_metrics_dummy backend (no-op, default) - Add hackney_metrics_prometheus backend (opt-in) - Rewrite hackney_metrics as API facade routing to backends - Update hackney_manager to use new metrics API (request metrics) - Update hackney_pool to use new metrics API (pool metrics) - Remove external metrics library dependency Metric types fixed (issue #560): - Pool free_count/in_use_count now use gauges (not histograms) - Request active count now uses gauge (not counter) New metric names (Prometheus-compatible): - hackney_requests_total (counter, labels: host) - hackney_requests_active (gauge, labels: host) - hackney_requests_finished_total (counter, labels: host) - hackney_request_duration_seconds (histogram, labels: host) - hackney_pool_free_count (gauge, labels: pool) - hackney_pool_in_use_count (gauge, labels: pool) - hackney_pool_checkouts_total (counter, labels: pool) Configuration: - Default: hackney_metrics_dummy (no-op, zero overhead) - To enable Prometheus: {hackney, [{metrics_backend, prometheus}]} Closes #772, closes #560
benoitc
force-pushed
the
feat/772-prometheus-metrics
branch
from
8d375cf to
eb693c4
Compare
This was referenced Jan 19, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
metricslibrary with hackney-native metrics abstractionChanges
hackney_metrics_backend.erl(behaviour),hackney_metrics_dummy.erl,hackney_metrics_prometheus.erlhackney_metrics.erl(API facade),hackney_manager.erl,hackney_pool.erl,hackney_util.erlmetricsdependency fromrebar.configandhackney.app.srcNew Metrics (Prometheus-compatible names)
hackney_requests_totalhackney_requests_activehackney_requests_finished_totalhackney_request_duration_secondshackney_pool_free_counthackney_pool_in_use_counthackney_pool_checkouts_totalConfiguration
Closes #772, closes #560