fix: improve reliability of proxy mock server tests #810
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix race condition in socket handoff by making it synchronous:
- Handler now blocks waiting for socket via message
- Socket is sent after controlling_process completes
- This ensures handler never tries to use socket before ownership
transfer is complete
- Increase timeouts for CI reliability:
- Accept timeout: 100ms -> 500ms
- Recv timeouts: 5s -> 10s
- Connect timeouts: 5s -> 10s
- Socket handoff wait: 1s -> 10s
These changes address flaky proxy integration tests that occasionally
failed on Linux x86_64 OTP-28 CI runners with errors like
{connect_proxy_failed, proxy_error} and {socks5_proxy_failed, badarg}.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Background
Proxy integration tests were occasionally failing on Linux x86_64 OTP-28 CI runners with errors like
{connect_proxy_failed, proxy_error}and{socks5_proxy_failed, badarg}.The root cause was a race condition in socket handoff: the spawned handler process could try to use the socket before
gen_tcp:controlling_processcompleted. The fix ensures the handler blocks until the socket is explicitly sent to it after ownership transfer.