Add checks: write permission to PR benchmark workflows#8
Merged
Conversation
The GitHub Actions how-to docs now recommend both checks: write and pull-requests: write for the PR workflows. Add checks: write to pr_benchmarks.yml and fork_pr_benchmarks_track.yml to match. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Bencher Report| Branch | checks-write-permission |
| Testbed | ubuntu-latest |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result nanoseconds (ns) (Result Δ%) | Upper Boundary nanoseconds (ns) (Limit %) |
|---|---|---|---|
| bencher::mock_0 | 📈 view plot 🚷 view threshold | 5.59 ns(+11.41%)Baseline: 5.02 ns | 11.42 ns (48.99%) |
| bencher::mock_1 | 📈 view plot 🚷 view threshold | 19.16 ns(+22.34%)Baseline: 15.66 ns | 22.22 ns (86.21%) |
| bencher::mock_2 | 📈 view plot 🚷 view threshold | 22.61 ns(-6.96%)Baseline: 24.31 ns | 31.09 ns (72.75%) |
| bencher::mock_3 | 📈 view plot 🚷 view threshold | 33.77 ns(-2.06%)Baseline: 34.48 ns | 42.02 ns (80.36%) |
| bencher::mock_4 | 📈 view plot 🚷 view threshold | 46.94 ns(+5.69%)Baseline: 44.41 ns | 51.02 ns (92.00%) |
|
| Branch | fork/checks-write-permission |
| Testbed | ubuntu-latest |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result nanoseconds (ns) (Result Δ%) | Upper Boundary nanoseconds (ns) (Limit %) |
|---|---|---|---|
| bencher::mock_0 | 📈 view plot 🚷 view threshold | 1.00 ns(-80.08%)Baseline: 5.02 ns | 11.42 ns (8.76%) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Match bencherdev/bencher#895, which makes
bencher run --github-actionsalways create aBencher ReportGitHub Check (so it can gate branch protection as a required status check). Creating the check needs thechecks: writepermission.Add
checks: writealongside the existingpull-requests: writein the two workflows that runbencher run --github-actionson pull requests:pr_benchmarks.ymlfork_pr_benchmarks_track.ymlThis mirrors the canonical snippets updated in #895 (
pull-requests-code.mdxandpull-requests-fork-track-code.mdx), withchecks: writelisted beforepull-requests: write.base_benchmarks.ymlalready hadchecks: write; the closed/run workflows need no permissions block.Note: the check is best-effort, so a missing
checks: writeonly produces a warning rather than failing the run, but setting it is required for the Check to actually appear.🤖 Generated with Claude Code