Use --key/BENCHER_API_KEY instead of deprecated --token#7
Merged
Conversation
Bencher deprecated user API tokens in favor of API keys (bencherdev/bencher#897). Update all authenticating workflows to pass the credential via the --key option and the BENCHER_API_KEY secret. Also restore the missing line-continuation backslash on the --branch line in pr_benchmarks.yml so the bencher run command matches the canonical docs. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Bencher Report| Branch | api-token-to-key |
| Testbed | ubuntu-latest |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result nanoseconds (ns) (Result Δ%) | Upper Boundary nanoseconds (ns) (Limit %) |
|---|---|---|---|
| bencher::mock_0 | 📈 view plot 🚷 view threshold | 3.14 ns(-38.92%)Baseline: 5.15 ns | 11.38 ns (27.63%) |
| bencher::mock_1 | 📈 view plot 🚷 view threshold | 10.86 ns(-30.35%)Baseline: 15.59 ns | 22.18 ns (48.95%) |
| bencher::mock_2 | 📈 view plot 🚷 view threshold | 20.21 ns(-16.39%)Baseline: 24.17 ns | 30.79 ns (65.64%) |
| bencher::mock_3 | 📈 view plot 🚷 view threshold | 36.23 ns(+5.02%)Baseline: 34.49 ns | 42.17 ns (85.91%) |
| bencher::mock_4 | 📈 view plot 🚷 view threshold | 44.51 ns(-0.08%)Baseline: 44.54 ns | 50.99 ns (87.30%) |
|
| Branch | fork/api-token-to-key |
| Testbed | ubuntu-latest |
Click to view all benchmark results
| Benchmark | Latency | Benchmark Result nanoseconds (ns) (Result Δ%) | Upper Boundary nanoseconds (ns) (Limit %) |
|---|---|---|---|
| bencher::mock_0 | 📈 view plot 🚷 view threshold | 1.00 ns(-80.57%)Baseline: 5.15 ns | 11.38 ns (8.79%) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bencher deprecated user API tokens in favor of API keys (bencherdev/bencher#897), which is now deployed and released. This updates the example workflows to match the released convention.
--token '${{ secrets.BENCHER_API_TOKEN }}'→--key '${{ secrets.BENCHER_API_KEY }}'in all 5 authenticating workflows (bencher run/bencher archive):base_benchmarks.ymlfork_pr_benchmarks_closed.ymlfork_pr_benchmarks_track.ymlpr_benchmarks.ymlpr_benchmarks_closed.yml--branch "$GITHUB_HEAD_REF"line inpr_benchmarks.ymlso the command matches the canonical docs (pre-existing bug, not part of #897).Verified the exact flag/secret convention against both the #897 diff and the live docs at https://bencher.dev/docs/how-to/github-actions/.
Action required after merge
The secret name changed, so the workflows now reference
secrets.BENCHER_API_KEY. Add aBENCHER_API_KEYrepository secret (a project API keybencher_run_*is sufficient, since each workflow sets--project example). The oldBENCHER_API_TOKENsecret can then be removed.🤖 Generated with Claude Code