You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
ci.yml — Skip the release job when running on the cloud branch.
test.yml — Change the Docker image tag from registry.bencher.dev/bencher:<sha> to a local bench:ci tag during build.
track_benchmarks.yml / track_pr_benchmarks.yml — Add a docker tag step to re-tag bench:ci to the registry name before pushing.
Review
Correctness — looks good. The change decouples the build step from the registry name, tagging locally as bench:ci and only applying the registry tag right before push. This is a clean separation of concerns: the build artifact is portable, and the registry-specific naming happens only in the workflows that actually push.
One minor observation on ci.yml:
The added condition github.ref != 'refs/heads/cloud' skips the release job on the cloud branch. This makes sense given the git flow (cloud is a deploy branch, not a release source), and is consistent with releases being cut from devel/tags.
Security: No new secret exposure. The docker login + docker push pattern is unchanged. The local bench:ci tag never leaves the runner unless explicitly pushed.
No issues found. The changes are minimal, well-scoped, and correct.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changeset retags a PR image with the
HEADSHA for PR benchmarks, instead of the ephemeral merge commit SHA.