Skip to content

Retag with the HEAD SHA for PR benchmarks#756

Merged
epompeii merged 3 commits intodevelfrom
u/ep/pr-head-sha
Mar 31, 2026
Merged

Retag with the HEAD SHA for PR benchmarks#756
epompeii merged 3 commits intodevelfrom
u/ep/pr-head-sha

Conversation

@epompeii
Copy link
Copy Markdown
Member

This changeset retags a PR image with the HEAD SHA for PR benchmarks, instead of the ephemeral merge commit SHA.

@epompeii epompeii self-assigned this Mar 30, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 30, 2026

🤖 Claude Code Review

PR: #756
Base: devel
Head: u/ep/pr-head-sha
Commit: 6f04f7dcbbe898362f59bba90698f617e14ffc61


PR Review: CI Workflow Changes

Commits: head_sha, rm_cloud_smoke_test, bencher:ci

Changes Summary

  1. ci.yml — Skip the release job when running on the cloud branch.
  2. test.yml — Change the Docker image tag from registry.bencher.dev/bencher:<sha> to a local bench:ci tag during build.
  3. track_benchmarks.yml / track_pr_benchmarks.yml — Add a docker tag step to re-tag bench:ci to the registry name before pushing.

Review

Correctness — looks good. The change decouples the build step from the registry name, tagging locally as bench:ci and only applying the registry tag right before push. This is a clean separation of concerns: the build artifact is portable, and the registry-specific naming happens only in the workflows that actually push.

One minor observation on ci.yml:
The added condition github.ref != 'refs/heads/cloud' skips the release job on the cloud branch. This makes sense given the git flow (cloud is a deploy branch, not a release source), and is consistent with releases being cut from devel/tags.

Security: No new secret exposure. The docker login + docker push pattern is unchanged. The local bench:ci tag never leaves the runner unless explicitly pushed.

No issues found. The changes are minimal, well-scoped, and correct.


Model: claude-opus-4-6

@epompeii epompeii merged commit 71b144d into devel Mar 31, 2026
36 checks passed
@epompeii epompeii deleted the u/ep/pr-head-sha branch March 31, 2026 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant