Skip to content

Fix noexcept #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dietmarkuehl merged 5 commits into from
Apr 27, 2026
Merged

Fix noexcept #91

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2e5f912
fix an probem with task's noexcept specifications
dietmarkuehl Apr 26, 2026
80b0688
bump to new execution version
dietmarkuehl Apr 27, 2026
533a2fa
Potential fix for pull request finding
dietmarkuehl Apr 27, 2026
e42e69e
clang-format
dietmarkuehl Apr 27, 2026
1a41ea1
minor formatting issue
dietmarkuehl Apr 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ FetchContent_Declare(
execution
# FETCHCONTENT_SOURCE_DIR_EXECUTION ${CMAKE_SOURCE_DIR}/../execution
GIT_REPOSITORY https://github.com/bemanproject/execution
GIT_TAG cad563e
GIT_TAG afde940
SYSTEM
FIND_PACKAGE_ARGS
0.2.0
Expand Down
8 changes: 5 additions & 3 deletions include/beman/task/detail/task.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ class task {
using completion_signatures = ::beman::execution::detail::meta::combine<
::beman::execution::completion_signatures<beman::task::detail::completion_t<Value>,
::beman::execution::set_stopped_t()>,
::beman::task::detail::error_types_of_t<Env> >;
::beman::task::detail::error_types_of_t<Env>>;
template <typename Ev>
auto get_completion_signatures(const Ev&) const& noexcept -> completion_signatures {
return {};
Expand All @@ -70,8 +70,10 @@ class task {
~task() = default;

template <typename Receiver>
auto connect(Receiver receiver) && -> state<Receiver> {
return state<Receiver>(std::forward<Receiver>(receiver), std::move(this->handle));
auto connect(Receiver&& receiver) && noexcept(
noexcept(state<std::remove_cvref_t<Receiver>>(std::forward<Receiver>(receiver), std::move(this->handle))))
-> state<std::remove_cvref_t<Receiver>> {
return state<std::remove_cvref_t<Receiver>>(std::forward<Receiver>(receiver), std::move(this->handle));
}
template <typename ParentPromise>
auto as_awaitable(ParentPromise&) && -> ::beman::task::detail::awaiter<Value, Env, promise_type, ParentPromise> {
Expand Down
Loading