lastgenre: Test empty last.fm result doesnt wipe#6608
Open
Conversation
Add a test case that proves that issue 5991 is fixed by now.
|
Thank you for the PR! The changelog has not been updated, so here is a friendly reminder to check if you need to add an entry. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6608 +/- ##
=======================================
Coverage 72.07% 72.07%
=======================================
Files 159 159
Lines 20633 20633
Branches 3273 3273
=======================================
Hits 14871 14871
Misses 5053 5053
Partials 709 709 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
PR add regression test for lastgenre plugin so existing multi-value genres not get wiped when Last.fm give no tags (issue #5991). This fit beets plugin test suite, guard against old bug come back.
Changes:
- Add new parametrized case in
test_get_genreforwhitelist: True+keep_existing: Truewith empty Last.fm results. - Assert "original fallback" keep both existing genres.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a test case that proves that issue 5991 is fixed by now.
Closes #5991 .