Skip to content

Allow chat events to be cancelled#326

Open
KabanFriends wants to merge 1 commit into
beanbeanjuice:masterfrom
maicra999:feat/cancellable-chat
Open

Allow chat events to be cancelled#326
KabanFriends wants to merge 1 commit into
beanbeanjuice:masterfrom
maicra999:feat/cancellable-chat

Conversation

@KabanFriends

Copy link
Copy Markdown

Pull Request


Description

Adds a simple condition check in onPlayerChat so that SimpleProxyChat will not send chat messages if the chat event was cancelled. Despite Velocity API marking PlayerChatEvent's result as deprecated, chat cancelling will still work if you have plugins like SignedVelocity installed.

Closes N/A

Related PRs: N/A

Prerequisites: N/A


Checklist

  • The code follows the style guidelines.
  • A self-review of the code was performed on GitHub.
  • Appropriate comments and javadocs were added in your code.
  • Appropriate changes have been made to the documentation.
  • Appropriate changes have been made to the README.md file.
  • Appropriate tests exist for this pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant