Skip to content

fix sandbox metrics chart#1696

Merged
luke-lombardi merged 1 commit into
mainfrom
ll/fix-sandbox-metrics-chart
Jun 17, 2026
Merged

fix sandbox metrics chart#1696
luke-lombardi merged 1 commit into
mainfrom
ll/fix-sandbox-metrics-chart

Conversation

@luke-lombardi

@luke-lombardi luke-lombardi commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

Summary by cubic

Fixes the sandbox metrics chart by scoping resource metrics to the selected app and correctly populating active sandbox timing.

  • Bug Fixes
    • Add app-scoped filtering to metrics timeseries: read app_id from the API, pass it in EventQuery, and filter S2 records by header or payload so charts only include the selected app.
    • Include AppID in EventContainerMetricsSchema and propagate through repositories and CloudEvents extensions to enable accurate matching.
    • Correct active sandbox timing: stop defaulting TimeToInteractiveMs/InteractiveAtMs to started time, allow history summary to override fields, and adjust summary-needed logic. Tests added for app scoping and timing enrichment.

Written for commit bef2705. Summary will update on new commits.

Review in cubic

@luke-lombardi luke-lombardi merged commit 1c32310 into main Jun 17, 2026
4 checks passed
@luke-lombardi luke-lombardi deleted the ll/fix-sandbox-metrics-chart branch June 17, 2026 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant