ttl more keys#1644
Open
luke-lombardi wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
1 issue found across 13 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="pkg/api/v1/stub.go">
<violation number="1" location="pkg/api/v1/stub.go:619">
P2: Checkpoint policy is duplicated and already inconsistent between create and update paths. This can make API behavior diverge for serve stubs and increases future drift risk.</violation>
</file>
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
| } | ||
|
|
||
| if stubConfig.CheckpointEnabled { | ||
| if stub.Type.IsServe() { |
Contributor
There was a problem hiding this comment.
P2: Checkpoint policy is duplicated and already inconsistent between create and update paths. This can make API behavior diverge for serve stubs and increases future drift risk.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At pkg/api/v1/stub.go, line 619:
<comment>Checkpoint policy is duplicated and already inconsistent between create and update paths. This can make API behavior diverge for serve stubs and increases future drift risk.</comment>
<file context>
@@ -615,6 +615,21 @@ func (g *StubGroup) UpdateConfig(ctx echo.Context) error {
}
+ if stubConfig.CheckpointEnabled {
+ if stub.Type.IsServe() {
+ return HTTPBadRequest("Checkpoints are not supported for serve stubs")
+ }
</file context>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Add TTLs to more Redis keys to prevent stale state, and harden the checkpoint workflow with validations, timeouts, and better signaling. Also adds GPU options to cache benchmarks and minor metrics/instance fixes.
Bug Fixes
DefaultEndpointRequestTimeoutS); refresh TTL on acquire/release; tests added.podContainerConnectionTimeout); test added.scheduler:container:worker:indexon worker removal; test verifies key deletion.i.StubConfigfor container request secrets to avoid stale config in endpoint instances.network.ip_scantonetwork.ip_load.New Features
UpdateConfig: reject for serve stubs, multi-GPU or multiple GPU types, and when workspace storage is missing; test added.Create/UpdateCheckpointRPCs.b9bench): add--sandbox-gpuand--sandbox-gpu-countflags and include them in reports.Written for commit 5fe0a80. Summary will update on new commits.