Define Thumbor VERSION in runtime stage so image labels resolve correctly#332
Draft
Copilot wants to merge 3 commits into
Draft
Define Thumbor VERSION in runtime stage so image labels resolve correctly#332Copilot wants to merge 3 commits into
VERSION in runtime stage so image labels resolve correctly#332Copilot wants to merge 3 commits into
Conversation
Copilot
AI
changed the title
[WIP] Fix code based on review comment in PR #331
Define Thumbor Jun 1, 2026
VERSION in runtime stage so image labels resolve correctly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The linked review comment identified that
$VERSIONwas only defined in the build stage, causing runtime image labels to expand to empty values. This updates the Thumbor Dockerfile so metadata labels publish the intended7.8.0version.What changed
VERSION=7.8.0to the runtime-stageENVblock indockerfiles/thumbor/Dockerfile.Why this matters
org.label-schema.versionandorg.opencontainers.image.versionnow resolve to the expected version instead of an empty string.ENV \ DEBIAN_FRONTEND=noninteractive \ PYTHONUSERBASE=/app \ PATH=$PATH:/app/bin/ \ VERSION=7.8.0