Skip to content

fix: Allow dependency to be use with Gradle 9 #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
validcube wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: Allow dependency to be use with Gradle 9 #48

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions system_theme/android/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ buildscript {
ext.kotlin_version = '1.7.0'
repositories {
google()
jcenter()
mavenCentral()
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot Mar 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

While replacing jcenter() with mavenCentral() is a necessary step for Gradle 9 compatibility, this change alone is not sufficient. To achieve the goal of this PR, several other dependencies need to be updated:

  1. Android Gradle Plugin (AGP): The current version 4.1.0 (line 12) is not compatible with Gradle 9. You should update it to a more recent version, for example 8.3.2, which is compatible with Gradle 8.4+.
  2. Kotlin Version: The AGP update will require a corresponding update to the Kotlin version (1.7.0 on line 5). For AGP 8.3.2, the compatible Kotlin version is 1.9.22.
  3. Gradle Wrapper: The project's Gradle wrapper is configured for Gradle 6.7 (gradle-wrapper.properties). This must be updated to a version compatible with the new AGP, such as Gradle 8.4.

Without these changes, the project will not be buildable with Gradle 9, defeating the purpose of this PR.

Copy link
Copy Markdown
Contributor Author

@validcube validcube Mar 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct, this PR only make it so that you can build Android app with Gradle 9 using this library.

The library is working as intended on project built with Gradle 9

Screenshot_20260304-115700.png

}

dependencies {
Expand All @@ -17,7 +17,7 @@ buildscript {
rootProject.allprojects {
repositories {
google()
jcenter()
mavenCentral()
}
}

Expand Down