Skip to content

AB#32745 - Fixed header menu highlight on detail and configuration pages#2437

Merged
JamesPasta merged 2 commits into
devfrom
feature/AB#32745-Header-Menue-Highlight
May 11, 2026
Merged

AB#32745 - Fixed header menu highlight on detail and configuration pages#2437
JamesPasta merged 2 commits into
devfrom
feature/AB#32745-Header-Menue-Highlight

Conversation

@hasanpour
Copy link
Copy Markdown
Contributor

No description provided.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the UX2 theme’s client-side “active menu” selection so the top navbar highlights correctly on detail/sub-pages, and adds a per-page override hook for pages whose URL doesn’t match a navbar link.

Changes:

  • Added longest-prefix URL matching in layout.js to highlight the closest matching navbar item for detail/sub-pages.
  • Introduced a page-level override via data-active-nav on <body> and set it for Payment History details to map to the Payments menu.
  • Minor whitespace cleanup in Payment History details page header setup.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
applications/Unity.GrantManager/src/Unity.GrantManager.Web/Pages/PaymentHistory/Details.cshtml Sets ViewData["ActiveNavHref"] to force the Payments menu item active for this page.
applications/Unity.GrantManager/modules/Unity.Theme.UX2/src/Unity.Theme.UX2/wwwroot/themes/ux2/layout.js Implements exact-match, longest-prefix fallback, and page override logic for navbar active state.
applications/Unity.GrantManager/modules/Unity.Theme.UX2/src/Unity.Theme.UX2/Themes/UX2/Layouts/Application.cshtml Adds data-active-nav attribute on <body> to support page-level override.

@github-actions
Copy link
Copy Markdown

🧪 Unit Test Results (Parallel Execution)

Tests

📊 Summary

Result Count
✅ Passed 703
❌ Failed 0
⚠️ Skipped 0

📄 HTML Reports

  • Merged Tests (HTML): Included in artifacts
    Generated automatically by CI.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@sonarqubecloud
Copy link
Copy Markdown

@JamesPasta JamesPasta merged commit 3a77566 into dev May 11, 2026
24 checks passed
@JamesPasta JamesPasta deleted the feature/AB#32745-Header-Menue-Highlight branch May 11, 2026 23:35
@github-actions
Copy link
Copy Markdown

🧪 Unit Test Results (Parallel Execution)

Tests

📊 Summary

Result Count
✅ Passed 703
❌ Failed 0
⚠️ Skipped 0

📄 HTML Reports

  • Merged Tests (HTML): Included in artifacts
    Generated automatically by CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants