bugfix/AB#31165 - Email - Fix dropped CC and BCC contacts #2103
Merged
JamesPasta merged 3 commits intodevfrom Mar 6, 2026
Merged
bugfix/AB#31165 - Email - Fix dropped CC and BCC contacts #2103JamesPasta merged 3 commits intodevfrom
JamesPasta merged 3 commits intodevfrom
Conversation
🧪 Unit Test Results (Parallel Execution)📊 Summary
📄 HTML Reports
|
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors CHES email payload construction in the Notifications module to better align with the expected schema and to avoid sending optional fields when they aren’t provided.
Changes:
- Added an
excludeTemplateflag to control whethertemplateNameis included in the outbound CHES payload. - Only includes
cc/bccfields in the payload when they have values (avoids sendingnull). - Updated
EmailLogmapping forcc/bccto safely handle absent fields.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...ifications/src/Unity.Notifications.Application/EmailNotificaions/EmailNotificationManager.cs
Outdated
Show resolved
Hide resolved
🧪 Unit Test Results (Parallel Execution)📊 Summary
📄 HTML Reports
|
plavoie-BC
changed the title
🧪 Unit Test Results (Parallel Execution)📊 Summary
📄 HTML Reports
|
JamesPasta
approved these changes
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request overview
Refactors CHES email payload construction in the Notifications module to better align with the expected schema and to avoid sending optional fields when they aren’t provided.
Changes:
excludeTemplateflag to control whethertemplateNameis included in the outbound CHES payload.cc/bccfields in the payload when they have values (avoids sendingnull).EmailLogmapping forcc/bccto safely handle absent fields.