Test by JamesPasta · Pull Request #1959 · bcgov/Unity

JamesPasta · 2026-01-27T23:07:59Z

No description provided.

- Enhanced DataTable state restoration logic to better handle column search and visibility, added robust error handling for state corruption - Improved global export of utility functions in table-utils.js - Added a check in GrantApplications/Index.js to ensure createNumberFormatter is loaded before use

- Add specific styling for the .cstm-save-view dropdown menu and its empty states, including border and padding adjustments to improve visual consistency

…8-Fix-Sonarqube-Errors

Bugfix/ab#31378 fix sonarqube errors

…om/bcgov/Unity into feature/AB#31366-SonarQubeTechDebt

AB#31628 remove obsolete and add replacement for breadcrumb

…-security-patch AB#31640 npm package update to lodash 4.17.23 (latest)

feature/AB#29486-RemoveSeriLog

…arnings feature/AB#31361 - Update NPM Packages

…e-InvalidCastException AB#31644: ChesHttpStatusCode InvalidCastException Fix

Dev

…on-datetime-format AB#31599: Use Pacific Timezone for all dates in FSB-AP email

…nmodule AB#31636 remove unused emailsender registration

…ectoral AB#31647 drop old Electoral District column

…rojectApplicantInfoAsync AB#31641 - remove dead code - UpdateProjectApplicantInfoAsync

Dev

...ions/Unity.GrantManager/src/Unity.GrantManager.Application/Applicants/ApplicantAppService.cs

            newApplicantAgent.IdentityName = intakeMap.ApplicantAgent?.name ?? "";
            newApplicantAgent.IdentityEmail = intakeMap.ApplicantAgent?.email ?? "";
+
+            newApplicantAgent.OidcSubUser = intakeMap.ApplicantAgent?.oidc_sub_user;              


...ions/Unity.GrantManager/src/Unity.GrantManager.Application/Applicants/ApplicantAppService.cs

            newApplicantAgent.IdentityEmail = intakeMap.ApplicantAgent?.email ?? "";
+
+            newApplicantAgent.OidcSubUser = intakeMap.ApplicantAgent?.oidc_sub_user;              
+            newApplicantAgent.IdentityProvider = intakeMap.ApplicantAgent?.identity_provider ?? "";


....GrantManager/src/Unity.GrantManager.Application/GrantManagerApplicationAutoMapperProfile.cs

+        return indigenousOrgInd switch
+        {
+            true => "Yes",
+            false => "No",


...ifications/src/Unity.Notifications.Application/EmailNotificaions/EmailNotificationManager.cs

+                                                    string? emailBCC = null)
+        {
+            var toList = emailTo.ParseEmailList() ?? [];
+            var ccList = emailCC.ParseEmailList();


...ifications/src/Unity.Notifications.Application/EmailNotificaions/EmailNotificationManager.cs

+        {
+            var toList = emailTo.ParseEmailList() ?? [];
+            var ccList = emailCC.ParseEmailList();
+            var bccList = emailBCC.ParseEmailList();


...r/src/Unity.GrantManager.Application/GrantApplications/GrantApplicationsSummaryAppService.cs

+        public async Task<GetSummaryDto> GetSummaryAsync(Guid applicationId)
+        {
+            var query = from application in await applicationRepository.GetQueryableAsync()
+                        join applicationForm in await applicationFormRepository.GetQueryableAsync() on application.ApplicationFormId equals applicationForm.Id


...src/Unity.GrantManager.Web/Views/Shared/Components/CustomFields/CustomFieldsViewComponent.cs

+
+            var applicationFormId = formVersion?.ApplicationFormId;
+            var applicationForm = applicationFormId.HasValue 
+                ? await applicationFormRepository.FindAsync(x => x.Id == applicationFormId.Value)


.../Unity.Payments/src/Unity.Payments.Application/Domain/Services/PaymentRequestQueryManager.cs

+                    foreach (var expenseApproval in paymentRequestDto.ExpenseApprovals)
+                    {
+                        if (expenseApproval.DecisionUserId.HasValue
+                            && userDictionary.TryGetValue(expenseApproval.DecisionUserId.Value, out var expenseApprovalUserDto))
+                        {
+                            expenseApproval.DecisionUser = expenseApprovalUserDto;
+                        }
+                    }


...nts/src/Unity.Payments.Application/PaymentRequests/Notifications/FsbPaymentExcelGenerator.cs

+            foreach (var timeZoneId in PacificTimeZoneIanaIds)
+            {
+                if (TimeZoneInfo.TryFindSystemTimeZoneById(timeZoneId, out var timeZone))
+                {
+                    return timeZone;
+                }
+            }


...ications/Unity.GrantManager/src/Unity.GrantManager.Web/Pages/ApplicationForms/Mapping.cshtml

                        </div>
                    </div>
                    <div class="col-4">
-                        <div class="intake-mapping-content">
-                            <div id="intake-map-available-fields-column" class="col" style="overflow-y:scroll"></div>
+                        <div class="tab-content unt-tab-content" id="nav-tabContent">
+                            <!--Tab Content: Mapping-->
+                            <div class="tab-pane fade show active" id="nav-intake-fields" role="tabpanel"
+                                aria-labelledby="nav-intake-fields-tab">
+
+                                <div class="intake-mapping-content">
+                                    <div id="intake-map-available-fields-column" class="col" style="overflow-y:scroll">
+                                    </div>
+                                </div>
+                            </div>
+                            <!--Tab Content: Worksheet Fields-->
+                            <div class="tab-pane fade" id="nav-worksheet-fields" role="tabpanel"
+                                aria-labelledby="nav-worksheet-fields-tab">
+                                <div class="worksheet-mapping-content">
+                                    <div id="worksheet-map-available-fields-column" class="col"
+                                        style="overflow-y:scroll">
+                                    </div>
+                                </div>
+                            </div>
                        </div>
                    </div>
                </div>
-                <div class="row">
-                    <div class="col-12">
-                        <div class="buttons">
-                            <div class="buttons-div">
-                                <abp-button id="btn-save"
-                                            text="Save"
-                                            icon-type="Other"
-                                            icon="fl fl-save"
-                                            class="btn unt-btn-primary btn-primary mx-1"
-                                            style="pointer-events: all;"
-                                            abp-tooltip="Save the Scoresheet and the Mapping of CHEFS fields to Unity Fields"
-                                            button-type="Primary" />
-                                <abp-button id="btn-edit"
-                                            text="Edit Mapping"
-                                            icon-type="Other"
-                                            data-target="#editMappingModal"
-                                            icon="fl fl-edit"
-                                            class="btn unt-btn-primary btn-primary mx-1"
-                                            data-toggle="modal"
-                                            style="pointer-events: all;"
-                                            abp-tooltip="Edit the Mapping JSON Manually"
-                                            button-type="Primary" />
-                                <abp-button id="btn-reset"
-                                            text="Reset Mapping"
-                                            icon-type="Other"
-                                            icon="fl fl-undo"
-                                            class="btn unt-btn-outline-primary btn-outline-primary mx-1"
-                                            abp-tooltip="This button resets the mapping to the last saved state" />
-                                <abp-button id="btn-back"
-                                            text="Back"
-                                            class="btn unt-btn-outline-primary btn-outline-primary mx-1"
-                                            abp-tooltip="Navigate back to the Forms" />
-                            </div>
+            </div>
+            <div class="row">
+                <div class="col-12">
+                    <div class="buttons">
+                        <div class="buttons-div">
+                            <abp-button id="btn-save" text="Save" icon-type="Other"
+                                class="btn unt-btn-primary btn-primary mx-1" style="pointer-events: all;"
+                                abp-tooltip="Save the Scoresheet and the Mapping of CHEFS fields to Unity Fields"
+                                button-type="Primary" />
+                            <abp-button id="btn-edit" text="Edit Mapping" icon-type="Other" data-target="#editMappingModal"
+                                icon="fl fl-edit" class="btn unt-btn-primary btn-primary mx-1" data-toggle="modal"


Feature/ab#9999 fix merge conflict

github-actions · 2026-01-27T23:27:06Z

🧪 Unit Test Results (Parallel Execution)

📊 Summary

Result	Count
✅ Passed	`289`
❌ Failed	`0`
⚠️ Skipped	`0`

📄 HTML Reports

Merged Tests (HTML): Included in artifacts
Generated automatically by CI.

Copilot

Pull request overview

This PR is a broad refactor/cleanup plus feature work across the GrantManager solution, including new UI components, permissions, integrations, and schema changes.

Changes:

Introduces new CustomFields widget/controller and related styling for form/worksheet configuration.
Adds FSB payment notification tracking (new fields, event flow from Notifications → Payments, UI column).
Performs various refactors/cleanup: service/interface adjustments, routing tweaks, dependency/package/config tidy-ups, and migrations.

Reviewed changes

Copilot reviewed 219 out of 230 changed files in this pull request and generated 14 comments.

Show a summary per file

File	Description
applications/Unity.GrantManager/src/Unity.GrantManager.Web/Views/Shared/Components/CustomFields/CustomFieldsViewComponent.cs	Adds CustomFields widget ViewComponent and bundles
applications/Unity.GrantManager/src/Unity.GrantManager.Web/Views/Shared/Components/CustomFields/CustomFieldsController.cs	Adds POST handler for updating worksheet link ordering
applications/Unity.GrantManager/modules/Unity.Notifications/src/Unity.Notifications.Application/Integrations/RabbitMQ/EmailConsumer.cs	Publishes FSB email-sent event + records CHES status
applications/Unity.GrantManager/src/Unity.GrantManager.HttpApi/Controllers/AttachmentController.cs	Refactors invalid file-type validation logic
applications/Unity.GrantManager/src/Unity.GrantManager.EntityFrameworkCore/Repositories/PersonRepository.cs	Refactors OIDC subject lookup logic

Files not reviewed (1)

applications/Unity.AutoUI/package-lock.json: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-28T00:28:43Z

...er/src/Unity.GrantManager.Web/Views/Shared/Components/CustomFields/CustomFieldsController.cs

+            var formVersion = await applicationFormVersionAppService.GetByChefsFormVersionId(model.ChefsFormVersionId);
+            _ = await worksheetLinkAppService
+                .UpdateWorksheetLinksAsync(new UpdateWorksheetLinksDto()
+                {
+                    CorrelationId = formVersion?.Id ?? Guid.Empty,
+                    CorrelationProvider = CorrelationConsts.FormVersion,
+                    WorksheetAnchors = tabLinks
+                });


If GetByChefsFormVersionId returns null, the code falls back to CorrelationId = Guid.Empty and still calls UpdateWorksheetLinksAsync. That risks writing/updating worksheet links under an empty correlation. Return NotFound/BadRequest when the form version can't be resolved, rather than proceeding with Guid.Empty.

Copilot · 2026-01-28T00:28:44Z

...ations/Unity.GrantManager/src/Unity.GrantManager.HttpApi/Controllers/AttachmentController.cs

+            foreach (var fileName in files.Where(file =>
            {
-                string FileType = System.IO.Path.GetExtension(file.FileName);
+                string FileType = Path.GetExtension(file.FileName);
                if (FileType.StartsWith('.'))
                {
                    FileType = FileType[1..];
                }
                return DisallowedFileTypes.Contains(FileType.ToLower());
-            }))
+            }).Select(source => source.FileName))
            {
-                ErrorList.Add(new ValidationResult("Invalid file type for " + source.FileName, [nameof(source.FileName)]));
+                ErrorList.Add(new ValidationResult("Invalid file type for " + fileName, [nameof(fileName)]));
            }


ValidationResult member names should refer to the model/property name (previously this was effectively "FileName"). Using [nameof(fileName)] produces "fileName", which is unlikely to match any bound field and may break client-side error association. Use nameof(IFormFile.FileName)/"FileName" (or another stable member name like nameof(files)) instead.

Copilot · 2026-01-28T00:28:44Z

...ity.GrantManager/src/Unity.GrantManager.EntityFrameworkCore/Repositories/PersonRepository.cs

        public async Task<Person?> FindByOidcSub(string oidcSub)
        {
            var dbSet = await GetDbSetAsync();
+            var compare = oidcSub.ToSubjectWithoutIdp().ToUpper();
            return await dbSet.AsQueryable()
-                .FirstOrDefaultAsync(s => s.OidcSub
-                .ToUpper()
-                .StartsWith(oidcSub.ToSubjectWithoutIdp()));                
+                .FirstOrDefaultAsync(s => s.OidcSub.StartsWith(compare));
        }


compare is uppercased, but the query now uses s.OidcSub.StartsWith(compare) without normalizing s.OidcSub. This becomes case-sensitive in PostgreSQL and will fail for existing/test data where OidcSub isn't already uppercase (e.g., GrantManagerTestDataSeedContributor seeds TestUser1). Either normalize OidcSub on write everywhere, or make the query case-insensitive again (e.g., ToUpper() on the column, or an EF-translatable case-insensitive comparison).

Copilot · 2026-01-28T00:28:44Z

...src/Unity.GrantManager.Web/Views/Shared/Components/CustomFields/CustomFieldsViewComponent.cs

+    [Widget(
+        RefreshUrl = "CustomFields/Refresh",
+        ScriptTypes = new[] { typeof(CustomFieldsScriptBundleContributor) },
+        StyleTypes = new[] { typeof(CustomFieldsStyleBundleContributor) },
+        AutoInitialize = true)]


RefreshUrl = "CustomFields/Refresh" points to a refresh endpoint that doesn't exist (there is only GrantApplications/CustomFields/update in CustomFieldsController). As-is, widget auto-refresh will 404. Add a Refresh action with a matching route (or update RefreshUrl to the actual route) that returns the CustomFields view component.

Copilot · 2026-01-28T00:28:44Z

...src/Unity.GrantManager.Web/Views/Shared/Components/CustomFields/CustomFieldsViewComponent.cs

+        public async Task<IViewComponentResult> InvokeAsync(string? formVersionId, string formName)
+        {
+            var model = new CustomFieldsViewModel { };
+            model.ChefsFormVersionId = Guid.Parse(formVersionId ?? Guid.Empty.ToString());
+            model.FormName = formName;


Guid.Parse(formVersionId ?? Guid.Empty.ToString()) will throw if formVersionId is null/empty/invalid (e.g., missing query arg). Prefer Guid.TryParse and return an empty/validation view model (or BadRequest) instead of throwing during view rendering.

Copilot · 2026-01-28T00:28:45Z

...ions/Unity.GrantManager/src/Unity.GrantManager.Application/Applicants/ApplicantAppService.cs

            newApplicantAgent.IdentityName = intakeMap.ApplicantAgent?.name ?? "";
            newApplicantAgent.IdentityEmail = intakeMap.ApplicantAgent?.email ?? "";
+
+            newApplicantAgent.OidcSubUser = intakeMap.ApplicantAgent?.oidc_sub_user;              


Condition is always not null because of dynamic call to method IsJObject.

Copilot · 2026-01-28T00:28:45Z

...ions/Unity.GrantManager/src/Unity.GrantManager.Application/Applicants/ApplicantAppService.cs

            newApplicantAgent.IdentityEmail = intakeMap.ApplicantAgent?.email ?? "";
+
+            newApplicantAgent.OidcSubUser = intakeMap.ApplicantAgent?.oidc_sub_user;              
+            newApplicantAgent.IdentityProvider = intakeMap.ApplicantAgent?.identity_provider ?? "";


Condition is always not null because of dynamic call to method IsJObject.

Copilot · 2026-01-28T00:28:46Z

....GrantManager/src/Unity.GrantManager.Application/GrantManagerApplicationAutoMapperProfile.cs

+        return indigenousOrgInd switch
+        {
+            true => "Yes",
+            false => "No",


Condition is always true because of ... => ....

Copilot · 2026-01-28T00:28:46Z

...er.Web/Views/Shared/Components/AssessmentScoresWidget/AssessmentScoresWidgetViewComponent.cs

+                        if (question.Type == QuestionType.SelectList)
+                        {
+                            question.Answer = ConvertNumericAnswerToSelectListValue(rawAnswer, question.Definition);
+                        }
+                        else
+                        {
+                            question.Answer = rawAnswer;
+                        }


Both branches of this 'if' statement write to the same variable - consider using '?' to express intent better.

Copilot · 2026-01-28T00:28:46Z

...er.Web/Views/Shared/Components/AssessmentScoresWidget/AssessmentScoresWidgetViewComponent.cs

+                    if (question.Type == QuestionType.SelectList)
+                    {
+                        question.Answer = ConvertNumericAnswerToSelectListValue(rawAnswer, question.Definition);
+                    }
+                    else
+                    {
+                        question.Answer = rawAnswer;
+                    }


Both branches of this 'if' statement write to the same variable - consider using '?' to express intent better.

samsaravillo and others added 30 commits January 5, 2026 21:07

SQ fix

f8eec35

Merge branch 'dev' into bugfix/AB#31145-filter-column-saved-view

3795b5f

sq fix

16f519d

SQ fix using optional chaining expression

47225e8

bugfix/AB#31003 UI fix in save view menu

ccf7897

- Add specific styling for the .cstm-save-view dropdown menu and its empty states, including border and padding adjustments to improve visual consistency

AB#30918: Set Payments Email Group to Static

abe2c2d

AB#31137 better handling of report config deletion

2ba8cb3

AB#31137 SQ and codeQL suggestions

6b7a783

feature/AB#31366-SonarQubeTechDebt

919c525

AB#31377 remove unused variables

6f65e4d

AB#31382 - discard unused tuple fields

c008b59

feature/AB#9000-FixMergeConflicts

94fa5af

AB#31378: Fix sonarqube issues - Part 1

0b24cd2

AB#31378: Remove unnecessary using

4b776b6

AB#31385 Update logging in migrations service

0d52cf7

feature/AB#31366-SonarQubeTechDebt

94eddb9

AB#31378: Dont hide WorksheetId of base class

3e7876a

Merge branch 'feature/AB#31366-SonarQubeTechDebt' into bugfix/AB#3137…

c212c44

…8-Fix-Sonarqube-Errors

AB#31385 CodeQL suggestions

8391020

feature/AB#31366-SonarQubeTechDebt-FixSwagger

0ad5de5

Merge pull request #1876 from bcgov/bugfix/AB#31378-Fix-Sonarqube-Errors

79232e4

Bugfix/ab#31378 fix sonarqube errors

AB#31378: Fix sonarqube and unit tests

7c03fa0

AB#31378: Fix sonarqube issues

baf9fd9

feature/AB#31366-SonarQubeTechDebt-FixUnitTest

652dd3a

Merge branch 'feature/AB#31366-SonarQubeTechDebt' of https://github.c…

e37db45

…om/bcgov/Unity into feature/AB#31366-SonarQubeTechDebt

feature/AB#31366-SonarQubeTechDebt-FixUnitTest

10d5202

feature/AB#31366-SonarQubeTechDebt-FixUnitTest

aa69746

feature/AB#31366-SonarQubeTechDebt

8e82652

feature/AB#31366-SonarQubeTechDebt

9b9dc25

AndreGAot and others added 20 commits January 21, 2026 15:28

AB#31628 inline constructor

4339edb

Merge pull request #1935 from bcgov/bugfix/AB#31628-remove-obsolete-sq

3867b5e

AB#31628 remove obsolete and add replacement for breadcrumb

AB#31636 remove unused emailsender registration

0b4ac56

AB#31640 npm package update to lodash 4.17.23 (latest)

901bda7

feature/AB#29486-RemoveSeriLog

8a984e5

Merge pull request #1939 from bcgov/bugfix/AB#31640-AutoUI-npm-lodash…

2d7a12f

…-security-patch AB#31640 npm package update to lodash 4.17.23 (latest)

Merge pull request #1936 from bcgov/feature/AB#29486-RemoveSerilog

a12f455

feature/AB#29486-RemoveSeriLog

AB#31641 - remove dead code

40249a7

Merge pull request #1931 from bcgov/feature/AB#31361-dependabot-npm-w…

6c58ccc

…arnings feature/AB#31361 - Update NPM Packages

AB#31647 drop old column

1c3acb0

AB#31647 remove snapshot change

7a2f4ec

AB#31644: ChesHttpStatusCode InvalidCastException Fix

afcd4f5

Merge pull request #1943 from bcgov/bugfix/AB#31644-ChesHttpStatusCod…

2f33e42

…e-InvalidCastException AB#31644: ChesHttpStatusCode InvalidCastException Fix

Merge pull request #1944 from bcgov/dev

44f709e

Dev

Merge pull request #1934 from bcgov/bugfix/AB#31599-fsb-ap-notificati…

dadf4d0

…on-datetime-format AB#31599: Use Pacific Timezone for all dates in FSB-AP email

Merge pull request #1937 from bcgov/bugfix/AB#31636-grantmanagerdomao…

92fd96a

…nmodule AB#31636 remove unused emailsender registration

Merge pull request #1942 from bcgov/feature/AB#31647-deprecate-old-el…

d1a8541

…ectoral AB#31647 drop old Electoral District column

Merge pull request #1941 from bcgov/bugfix/AB#31641-deprecate-UpdateP…

7e2110f

…rojectApplicantInfoAsync AB#31641 - remove dead code - UpdateProjectApplicantInfoAsync

Merge pull request #1945 from bcgov/dev

24ff740

Dev

Merge branch 'main' into feature/AB#9999-FixMergeConflict

b94bdb0

github-code-quality bot found potential problems Jan 27, 2026

View reviewed changes

Merge pull request #1960 from bcgov/feature/AB#9999-FixMergeConflict

fc2b30e

Feature/ab#9999 fix merge conflict

JamesPasta requested review from DarylTodosichuk, Stephan-McColm and Copilot January 27, 2026 23:29

Copilot started reviewing on behalf of JamesPasta January 28, 2026 00:21 View session

Copilot AI reviewed Jan 28, 2026

View reviewed changes

DarylTodosichuk approved these changes Jan 28, 2026

View reviewed changes

DarylTodosichuk merged commit 3b2f133 into main Jan 28, 2026
34 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Test#1959

Test#1959
DarylTodosichuk merged 230 commits intomainfrom
test

JamesPasta commented Jan 27, 2026

Uh oh!

github-actions bot commented Jan 27, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Jan 28, 2026

Uh oh!

Copilot AI Jan 28, 2026

Uh oh!

Copilot AI Jan 28, 2026

Uh oh!

Copilot AI Jan 28, 2026

Uh oh!

Copilot AI Jan 28, 2026

Uh oh!

Copilot AI Jan 28, 2026

Uh oh!

Copilot AI Jan 28, 2026

Uh oh!

Copilot AI Jan 28, 2026

Uh oh!

Copilot AI Jan 28, 2026

Uh oh!

Copilot AI Jan 28, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Conversation

JamesPasta commented Jan 27, 2026

Uh oh!

github-actions bot commented Jan 27, 2026

🧪 Unit Test Results (Parallel Execution)

📊 Summary

📄 HTML Reports

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Jan 28, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 28, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 28, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 28, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 28, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 28, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 28, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 28, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 28, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 28, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants