Skip to content
Merged

Dev #1465

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
f113d04
bugfix/ab#29195 sonarQube fix and clean up code
samsaravillo Jun 27, 2025
e84598b
Merge branch 'dev' into bugfix/ab#29195-saved-views-columns-issue
samsaravillo Jun 27, 2025
5618949
Merge pull request #1458 from bcgov/bugfix/ab#29195-saved-views-colum…
JamesPasta Jun 27, 2025
22789ff
bugfix/AB#29308-SuplierOrgMatch
jimmyPasta Jun 27, 2025
d12dd71
bugfix/AB#29308-SuplierOrgMatch
jimmyPasta Jun 27, 2025
366bb82
feature/AB#29093-Added-Clear-Orgbook-Button
cyrusparsons Jun 30, 2025
6c33ef9
Merge remote-tracking branch 'origin/dev' into feature/AB#29093-Allow…
cyrusparsons Jun 30, 2025
d367553
feaure/AB#29093 Trigger change of text-based fields
cyrusparsons Jun 30, 2025
003fe70
feature/AB#29093 Attempting to fix diff
cyrusparsons Jun 30, 2025
04a4f04
AB#29137 - Add Program Manager Permissions for Tags to Data Seeder
plavoie-BC Jun 30, 2025
1bdf274
Merge branch 'dev' into bugfix/AB#29308-SupplierRegOrg/ChangedRequest…
plavoie-BC Jun 30, 2025
7913cd2
bugfix/ab#29196 save view state and params issue
samsaravillo Jul 1, 2025
4c73430
Merge pull request #1462 from bcgov/bugfix/ab#29196-saved-view-active…
JamesPasta Jul 2, 2025
4a871a9
Merge pull request #1461 from bcgov/bugfix/AB#29137-tags-permissions-…
JamesPasta Jul 2, 2025
39bc4d4
feature/AB#29093 Added back end of comment
cyrusparsons Jul 2, 2025
9c1eb70
Merge pull request #1459 from bcgov/bugfix/AB#29308-SupplierRegOrg/Ch…
JamesPasta Jul 2, 2025
42b8b5e
Merge pull request #1460 from bcgov/feature/AB#29093-Allow-Removal-of…
JamesPasta Jul 2, 2025
d019247
feature/AB#29422
Stephan-McColm Jul 3, 2025
6b0160f
Merge pull request #1464 from bcgov/feature/AB#29422-Cypress-Spec-Update
JamesPasta Jul 3, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
354 changes: 183 additions & 171 deletions applications/Unity.AutoUI/cypress/e2e/chefsdata.cy.ts

Large diffs are not rendered by default.

Original file line number Diff line number Diff line change
Expand Up @@ -27,21 +27,21 @@ $(function () {

function validateMatchingSupplierToOrgInfo() {
const supplierName = (UIElements.supplierName.val() || '').toLowerCase().trim();

if (!supplierName) {
UIElements.supplierOrgInfoErrorDiv.toggleClass('hidden', true);
return;
}
let isMatch = true;

const orgName = (UIElements.orgName.val() || '').toLowerCase().trim();
const nonRegisteredOrgName = (UIElements.nonRegisteredOrgName.val() || '').toLowerCase().trim();

if(orgName != '') {
isMatch = !supplierName || !orgName || supplierName === orgName;
} else if(nonRegisteredOrgName != '') {
isMatch = !supplierName || !nonRegisteredOrgName || supplierName === nonRegisteredOrgName;
}
// Match if either orgName or nonRegisteredOrgName matches supplierName
const isMatch =
(!orgName && !nonRegisteredOrgName) ||
supplierName === orgName ||
supplierName === nonRegisteredOrgName;

UIElements.supplierOrgInfoErrorDiv.toggleClass('hidden', isMatch);
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -163,6 +163,13 @@ function initializeDataTable(options) {
data.columns[originalIdx].uniqueKey = originalCol.name;
});

if (Array.isArray(data.order)) {
data.orderByUniqueKey = data.order.map(([colIdx, dir]) => {
const col = data.columns[colIdx];
return col ? { uniqueKey: col.uniqueKey, dir } : null;
}).filter(x => x);
}

let hasFilter =
data.columns.some((value) => value.search.search !== '') ||
searchValue !== '';
Expand All @@ -175,6 +182,16 @@ function initializeDataTable(options) {
let stateCorrupted = false;
const tableId = settings.sTableId || settings.nTable.id;
const aoColumns = settings.aoColumns;

// Restore order from uniqueKey if available
if (Array.isArray(data.orderByUniqueKey)) {
data.order = data.orderByUniqueKey.map(orderObj => {
// Find the current index for this uniqueKey
const idx = data.columns.findIndex(col => col.uniqueKey === orderObj.uniqueKey);
return [idx, orderObj.dir];
}).filter(([idx]) => idx !== -1);
}

data.columns.forEach((column, index) => {
if (aoColumns[index] + '' != 'undefined') {
const name = aoColumns[index].name;
Expand Down Expand Up @@ -209,7 +226,7 @@ function initializeDataTable(options) {
try {
dtApi = new $.fn.dataTable.Api(settings);

if (!dtApi || !dtApi.table().node()) {
if (!dtApi?.table()?.node()) {
throw new Error('Invalid DataTable instance.');
}

Expand Down Expand Up @@ -239,7 +256,15 @@ function initializeDataTable(options) {
);
}

dtApi.columns.adjust().draw(false);
if (Array.isArray(data.order) && data.order.length > 0) {
const adjustedOrder = data.order.map(([visualIdx, dir]) => {
const originalIdx = dtApi.colReorder?.transpose?.(visualIdx);
return [originalIdx, dir];
});
dtApi.order(adjustedOrder).draw();
} else {
dtApi.columns.adjust().draw(false);
}
} catch (err) {
console.warn('StateLoaded failed:', err);
const stateKey = `DataTables_${tableId}_${window.location.pathname}`;
Expand Down Expand Up @@ -408,10 +433,11 @@ function getSelectColumn(title, dataField, uniqueTableId) {
className: 'notexport text-center',
data: dataField,
name: 'select',
index: 0,
render: function (data) {
return `<input class="checkbox-select chkbox" id="row_${data}" type="checkbox" value="" title="${title}">`;
},
index: 0,

};
}

Expand Down Expand Up @@ -511,26 +537,6 @@ function toggleFilterRow() {
$(this).popover('toggle');
$('#dtFilterRow').toggleClass('hidden');
}
function updateColvisButtonState($btn, api, colIndex) {
const visible = api.column(colIndex).visible();
$btn.toggleClass('dt-button-active', visible);
}

function syncColvisButtonStates(api) {
const aoColumns = api.settings()[0].aoColumns;

let x = $('.dt-button-collection .dt-button');
let z = $('.dt-button-collection a.dt-button');
$('.dt-button-collection a.dt-button').each(function () {
const $btn = $(this);
const colName = $btn.attr('data-cv-name');

const colIndex = aoColumns.findIndex((col) => col.name === colName);
if (colIndex !== -1) {
updateColvisButtonState($btn, api, colIndex);
}
});
}

function findColumnByTitle(title, dataTable) {
let columnIndex = dataTable
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,12 @@ public PermissionGrantsDataSeeder(IPermissionDataSeeder permissionDataSeeder)
GrantApplicationPermissions.Dashboard.RequestApprovedCount,
];

public readonly List<string> SettingManagement_Tags_CommonPermissions = [
UnitySelector.SettingManagement.Tags.Default,
UnitySelector.SettingManagement.Tags.Update,
UnitySelector.SettingManagement.Tags.Delete
];

public async Task SeedAsync(DataSeedContext context)
{
// Default permission grants based on role
Expand Down Expand Up @@ -109,6 +115,7 @@ await _permissionDataSeeder.SeedAsync(RolePermissionValueProvider.ProviderName,
GrantManagerPermissions.Intakes.Default,
GrantManagerPermissions.ApplicationForms.Default,

.. SettingManagement_Tags_CommonPermissions,
.. ReviewAndAssessment_CommonPermissions,
.. ApplicantInfo_CommonPermissions,
.. ProjectInfo_CommonPermissions,
Expand Down Expand Up @@ -162,10 +169,8 @@ await _permissionDataSeeder.SeedAsync(RolePermissionValueProvider.ProviderName,
GrantManagerPermissions.Organizations.ManageProfiles,
GrantApplicationPermissions.Approvals.BulkApplicationApproval,
GrantApplicationPermissions.Approvals.DeferAfterApproval,
UnitySelector.SettingManagement.Tags.Default,
UnitySelector.SettingManagement.Tags.Update,
UnitySelector.SettingManagement.Tags.Delete,

.. SettingManagement_Tags_CommonPermissions,
.. ReviewAndAssessment_CommonPermissions,
.. ApplicantInfo_CommonPermissions,
.. ProjectInfo_CommonPermissions,
Expand Down Expand Up @@ -204,6 +209,7 @@ await _permissionDataSeeder.SeedAsync(RolePermissionValueProvider.ProviderName,
GrantManagerPermissions.ApplicationForms.Default,


.. SettingManagement_Tags_CommonPermissions,
.. ReviewAndAssessment_CommonPermissions,
.. ApplicantInfo_CommonPermissions,
.. ProjectInfo_CommonPermissions,
Expand All @@ -212,9 +218,6 @@ await _permissionDataSeeder.SeedAsync(RolePermissionValueProvider.ProviderName,
.. Dashboard_CommonPermissions,

UnitySettingManagementPermissions.BackgroundJobSettings,
UnitySelector.SettingManagement.Tags.Default,
UnitySelector.SettingManagement.Tags.Update,
UnitySelector.SettingManagement.Tags.Delete
], context.TenantId);


Expand Down
Loading