Extract docker requirement source to single file#24
Draft
Hneuschmidt wants to merge 2 commits intomainfrom
Draft
Extract docker requirement source to single file#24Hneuschmidt wants to merge 2 commits intomainfrom
Hneuschmidt wants to merge 2 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a single file (
cwl/docker-requirement.yaml) that defines the docker image name (including the tag) for all cwl documents. This tag could then (still TODO) also be used to automatically generate and upload a docker image to the registry.Unfortunately I have not found a way to extract only the tag (without the image name) to a single
VERSIONfile, as the$includeand$importdirectives of CWL preprocessing do not support string concatenation to my knowledge.The docker image name / tag must be provided as a string and cannot be an expression, so we need to keep image name and tag combined in the same string.
In any case, this serves my purpose of having a single point to declare a version, it is just not as clean as hoped, the image name and registry must be prepended in the same file. This could be solved with a Makefile or similar, but that would require another manual step to generate
cwl/docker-requirement.yamlbefore pushing.