Merged
Conversation
Previously, closed tasks with older closed PRs might not show PR details because the batch fetch only retrieves the most recent 10 closed PRs. If a done task's PR was not in those most recent 10, it would show nil for PR info even though a PR exists. This change adds a fallback to individual branch fetching for any task whose branch wasn't found in the batch fetch. This ensures all visible closed tasks show their PR details when available, just like the detail view. Changes: - Modified refreshAllPRs() to fall back to GetPRForBranch() for tasks not found in the batch fetch results - Ensures closed/done tasks consistently display PR status badges and diff stats in the kanban view Fixes #1283 Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1283 - Ensures closed tasks consistently show PR details in the kanban view, just like the task detail view.
Problem
Previously, closed tasks with older closed PRs might not show PR details because:
Solution
Added a fallback mechanism in
refreshAllPRs()that:Changes
internal/ui/app.go:refreshAllPRs()to add fallback toGetPRForBranch()for tasks not found in batch resultsTest Plan
go test ./internal/ui/... ./internal/github/...)🤖 Generated with Claude Code