Merged
Conversation
The quick input feature (approve/deny executor prompts from the Kanban) was unreliable due to three issues: 1. After approve/deny, tasksNeedingInput was prematurely cleared in the executorRespondedMsg handler, causing the prompt preview to disappear even when the task was still blocked. Now we only clear the cached prompt content and let the natural status transition handle cleanup. 2. Blocked tasks were only detected via status transitions, so tasks already blocked on app startup or those that cycled through blocked→processing→blocked within one poll were missed. 3. Added GetActiveTaskWindows() to batch-check which tasks have active tmux windows, enabling reliable detection of blocked tasks that need quick input regardless of how they entered the blocked state. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
…-vie Resolve conflicts by adopting main's latestPermissionPrompt approach for detecting pending executor prompts via DB hook logs. This replaces the tmux window check (GetActiveTaskWindows) with a more robust DB-based detection that works regardless of tmux state. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tasksNeedingInputafter approve/deny — let the natural status transition (blocked → processing) handle cleanup insteadGetActiveTaskWindows()batch check to reliably detect blocked tasks with active tmux panes, catching tasks missed by transition detection (startup, rapid cycles)Root Cause
The quick input prompt preview would disappear after approve/deny because
executorRespondedMsgimmediately clearedtasksNeedingInput. If the task was still blocked (e.g., the executor hadn't processed the input yet), the UI wouldn't re-detect it because it only looked for status transitions to blocked, not tasks already in blocked state.Test plan
TestExecutorRespondedDoesNotClearNeedsInputvalidates the fixTestBlockedTasksDetectedOnInitialLoadvalidates initial load behaviorTestGetActiveTaskWindowsvalidates the batch tmux check🤖 Generated with Claude Code