feat: partInstances invalid state SOFIE-317 #69
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Move event listener removal into cleanup() to avoid duplication - Fix missing cleanup() call when segment is not found
This is a preparation step for the documents having multiple owners. In the current iteration, each document will remain with one owner.
…s within rundown/bucket
…nces as owners to existing docs # Conflicts: # meteor/server/publications/pieceContentStatusUI/checkPieceContentStatus.ts # packages/job-worker/src/ingest/model/implementation/SaveIngestModel.ts
… between ingest and playout
manager.ts: - Replace .indexOf() > -1 with .includes() for mode checks xbox-controller-device.ts and joycon-device.ts - Add readonly modifier to members that are never reassigned:
- Store bound handlers for gamepadconnected/gamepaddisconnected events - Remove event listeners in destroy() to prevent memory leaks - For joycon, also cancel any pending requestAnimationFrame in destroy()
…ackages-shared-ingest-and-playout feat: rework ExpectedPackages generation/management to share packages between ingest and playout
feat: UI piece retiming
…o/xbox-controller feat: Add XBox controller support with take button to prompter screen
properties not present in apiStudio needed to be taken from the existing studio refactor(EAV-588): extract `studioFrom` logic and add test coverage refactor(EAV-588): small changes for clarity fix(EAV-598): make `updateOverrides` respect deep property overrides, not generate invalid overrides, and correctly preserve existing overrides fix(EAV-588): add null checks
…idually (Sofie-Automation#1597) * chore: unify tsc for packages and meteor * chore: build docker images in ci without pushing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opening here first, to allow a review before sending upstream