Add support for Dash.js rendered subtitles#352
Add support for Dash.js rendered subtitles#352ryanmccartney wants to merge 15 commits intobbc:masterfrom
Conversation
eirikbjornr
left a comment
There was a problem hiding this comment.
LGTM overall! Got one question on setSubtitles and disableTextTracks
|
Just a thought on naming. I wonder if |
That makes sense, I'll adjust the naming to reflect this |
|
References to Dash.js subtitles have now been updated to Embedded subtitles |
|
I've submitted a PR to |
|
PR now brought up to date with 9.0.2 |
|
Replaced by #383 |
📺 What
Extends subtitle functionality by adding the ability to use Dash.js rendered subtitles if declared in an MPD rather than using the existing side-chain.
Allows the rendering of subtitles delivered in fragmented chunks, as used for low-latency playback.
It does not implement the current customisation options that are available in the existing side-chain as Dash.js provides no interface to access the customisation options present in the BBC fork of imscJS.
A currently open PR imscJS #257 would enable customisation on upstream imscJS and work on Dash.js (imscJS Styling would allow this functionality to be added retrospectively.
🛠 How
By setting a new override -
dashSubtitles, the side-chain is replaced by a newdashsubtitlesobject which enables text tracks in the MSE player✅ Testing [Semi-optional]
Tests have been added to cover changes to the subtitle selector. In addition, coverage of the new dashsubtitles.js object is provided.
Test Guidelines
♿ Accessibility [optional]
Provides optional subtitles when using low-latency playback through Bigscreen player without modifications to the existing side-chain rendering.