Stop treating projectile-consult.el as a standalone package#2099
Merged
Conversation
It ships inside the Projectile package but carried its own Version and Package-Requires headers, so build tooling mistook it for a separate package. Most recently that broke eldev-based test runs on Emacs 28.x: eldev enforced Consult's Emacs 29.1 floor on the whole project and refused to run. Drop the standalone headers; the module still declares its runtime needs (Consult 2.0+, hence Emacs 29.1+) in the file header, the manual, and the Eldev build config, which only pulls Consult in on Emacs 29.1+ (where it can be installed) and relies on the module byte-compiling cleanly without it elsewhere. The module now loads on every Emacs (it only soft-requires Consult), so the integration test can no longer gate on whether the module loads - it would run without Consult present and fail. Gate it on Consult itself instead, so the specs still self-skip on Emacs < 29.1.
bbatsov
force-pushed
the
fix/consult-in-package-module
branch
from
July 18, 2026 08:58
f6497e8 to
3ae9f12
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI on
masteris red on the Emacs 28.2 job, and it has nothing to do with any recent code change.projectile-consult.elships inside the Projectile package but carried its ownVersionandPackage-Requiresheaders, so build tooling treats it as a standalone package. A fresheldevpicked up on that and started enforcing Consult's Emacs 29.1 floor across the whole project, so the 28.2 run bails out with "Emacs version 29.1 is required" before a single spec runs. Same double life that caused #2037.So stop pretending it is a package and drop the two headers. Its runtime needs (Consult 2.0+, hence Emacs 29.1+) are unchanged and still spelled out in the file header, the manual, and the
Eldevconfig, which pulls Consult in only on Emacs 29.1+ and relies on the module byte-compiling cleanly without it elsewhere.eldev test)M-x checkdocwarnings