Add RISC-V Linux host toolchain support - #4237
Open
Xeonacid wants to merge 1 commit into
Open
Conversation
riscv64gc-unknown-linux-gnu is Rust tier 2 with host tools (https://doc.rust-lang.org/rustc/platform-support/riscv64gc-unknown-linux-gnu.html). rules_rust already listed it as a T2 target (PR bazelbuild#3487) but with host_tools = False, and it was missing from the default exec-triple map and from get_host_triple(). Native builds on RISC-V Linux then fail toolchain resolution with: No matching toolchains found for types @@rules_rust+//rust:toolchain_type Register a rust_linux_riscv64 repository set alongside the existing Linux aarch64/x86_64/s390x/ppc64le hosts, mark the triple as having host tools, and teach get_host_triple() to accept repository_ctx.os.arch == "riscv64". The host triple is riscv64gc-unknown-linux-gnu (G + C), not the bare riscv64-unknown-linux-gnu name.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
riscv64gc-unknown-linux-gnu is Rust tier 2 with host tools (https://doc.rust-lang.org/rustc/platform-support/riscv64gc-unknown-linux-gnu.html). rules_rust already listed it as a T2 target (PR #3487) but with host_tools = False, and it was missing from the default exec-triple map and from get_host_triple(). Native builds on RISC-V Linux then fail toolchain resolution with:
No matching toolchains found for types @@rules_rust+//rust:toolchain_type
Register a rust_linux_riscv64 repository set alongside the existing Linux aarch64/x86_64/s390x/ppc64le hosts, mark the triple as having host tools, and teach get_host_triple() to accept repository_ctx.os.arch == "riscv64". The host triple is riscv64gc-unknown-linux-gnu (G + C), not the bare riscv64-unknown-linux-gnu name.