Fix Windows GNU staticlib output naming - #4231
Merged
UebelAndre merged 1 commit intoAug 15, 2026
Merged
Conversation
cerisier
marked this pull request as ready for review
August 15, 2026 09:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make Rust static-library naming ABI-aware on Windows.
Rust emits
lib<crate>.afor the GNU and GNULLVM Windows ABIs, while MSVC emits<crate>.lib. The generated Rust toolchain currently selects.libfrom the operating system alone, anddetermine_lib_nameremoves thelibprefix for every Windows static library. As a result, Bazel declares an output different from the file emitted by rustc for Windows GNU-like targets.This change passes the target ABI through repository and toolchain generation, selects
.afor Windows GNU/GNULLVM static libraries, and preserves theirlibprefix. MSVC behavior and Windows dynamic-library naming remain unchanged.Regression coverage exercises the extension mapping, rendered toolchain metadata, final GNU/GNULLVM/MSVC static-library names, and the unchanged GNU
cdylibname.