Fixes BEP path handling for rust analyzer specs#4130
Merged
Conversation
Contributor
Author
|
cc @UebelAndre |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The rewrite of the Rust Analyzer auto-discovery pipeline (see #4075) introduced a bug for users who use
--experimental_convenience_symlinks=ignore(i.e. have no bazel-out symlink in their workspace).parse_output_group_pathsdocumentation suggests that output paths are always absoluterules_rust/tools/rust_analyzer/bep.rs
Lines 107 to 110 in dedf053
but that is not true for BEP events that trigger the fallback reconstruction path
rules_rust/tools/rust_analyzer/bep.rs
Lines 241 to 243 in dedf053
This PR detects those cases and anchors those paths to the execution root, making them also absolute.