Make compresslevel configurable for .tar.gz#888
Merged
aiuto merged 1 commit intobazelbuild:mainfrom Sep 16, 2024
Merged
Conversation
cgrindel
reviewed
Aug 29, 2024
Collaborator
cgrindel
left a comment
There was a problem hiding this comment.
Is there any way that we can test that the compress level value is being passed along to the command line correctly? Alternatively, can we add a test that at least uses the new attribute?
Contributor
Author
|
Hello, I added a simple test named |
aiuto
reviewed
Sep 2, 2024
21424d3 to
84b5c64
Compare
aiuto
approved these changes
Sep 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's the problem
The current tar packaging process is not efficient enough, as evidenced by:
How to solve
Add
compresslevel: strwhich can be"" (auto, 6) | "0" | "1" | ... | "9"(this is extracted from #887).