fix(test): package_naming_aggregate_test on Windows#1018
Open
rdesgroppes wants to merge 1 commit intobazelbuild:mainfrom
Open
fix(test): package_naming_aggregate_test on Windows#1018rdesgroppes wants to merge 1 commit intobazelbuild:mainfrom
package_naming_aggregate_test on Windows#1018rdesgroppes wants to merge 1 commit intobazelbuild:mainfrom
Conversation
rdesgroppes
force-pushed
the
fix-package_naming_aggregate_test-on-windows
branch
3 times, most recently
from
7550f82 to
9ce07db
Compare
rdesgroppes
requested review from
aiuto,
cgrindel and
meteorcloudy
as code owners
rdesgroppes
force-pushed
the
fix-package_naming_aggregate_test-on-windows
branch
from
9ce07db to
cdc5188
Compare
The test was failing on Windows: ``` ==================== Test output for //tests:package_naming_aggregate_test: ls: cannot access 'C:/[...]/bin/tests/package_naming_aggregate_test.exe.runfiles/_main/tests/test_naming_some_value.deb': No such file or directory ================================================================================ ``` It tried to directly access files in the `runfiles` directory, but on Windows Bazel uses by default a manifest file instead of creating actual symlinks. The change consists in adding a minimalistic version of the [rlocation()](https://github.com/bazelbuild/rules_shell/blob/main/shell/runfiles/runfiles.bash) helper function that: - when set, reads from `$RUNFILES_MANIFEST_FILE` to resolve paths, - otherwise uses `$TEST_SRCDIR` directly, as before. This allows to enable the test in Windows CI now it passes. Note on the stricter error handling: - `set -u` is to fail fast should any of the expected `TEST_*` environment variables be unbound, - `set -o pipefail` is to fail fast should either side of the `grep | cut` pipe fail.
rdesgroppes
force-pushed
the
fix-package_naming_aggregate_test-on-windows
branch
from
cdc5188 to
2e1411a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test was failing on Windows:
It tried to directly access files in the
runfilesdirectory, but on Windows Bazel uses by default a manifest file instead of creating actual symlinks.The change consists in adding a minimalistic version of the rlocation() helper function that:
$RUNFILES_MANIFEST_FILEto resolve paths,$TEST_SRCDIRdirectly, as before.This allows to enable the test in Windows CI now it passes.
Note on the stricter error handling:
set -uis to fail fast should any of the expectedTEST_*environment variables be unbound,set -o pipefailis to fail fast should either side of thegrep | cutpipe fail.