Support push_targets in container_bundle#2253
Open
codersasha wants to merge 2 commits intobazelbuild:masterfrom
Open
Support push_targets in container_bundle#2253codersasha wants to merge 2 commits intobazelbuild:masterfrom
codersasha wants to merge 2 commits intobazelbuild:masterfrom
Conversation
added 2 commits
May 9, 2023 10:04
|
This Pull Request has been automatically marked as stale because it has not had any activity for 180 days. It will be closed if no further activity occurs in 30 days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
container_bundleonly supports a strange dictionary format for images.What is the new behavior?
container_bundlecan take apush_targetsparameter, and the info for the image (repository, tag, etc) is taken from existing push rules. This also meanscontains_bundlesupports usingtag_files, and the subsequentpush-allrule can push using these tag files as well.Does this PR introduce a breaking change?
Other information