Revert "Update providers.bzl (#2077)"#2249
Open
jacobmou wants to merge 1 commit intobazelbuild:masterfrom
Open
Revert "Update providers.bzl (#2077)"#2249jacobmou wants to merge 1 commit intobazelbuild:masterfrom
jacobmou wants to merge 1 commit intobazelbuild:masterfrom
Conversation
This reverts commit 0768e1b. In the original patch bazelbuild#2077, `tag` and `stamp_input` fields of PushInfo were removed with the assumption that they become obsolete since bazel 5.0. However, bazel itself doesn't control our customized `PushInfo` provider. We have some downstream rules that are relying on these field and would like to keep using them in latest version of rules_docker.
jacobmou
requested review from
gravypod,
linzhp,
pcj,
smukherj1 and
uhthomas
as code owners
|
This Pull Request has been automatically marked as stale because it has not had any activity for 180 days. It will be closed if no further activity occurs in 30 days. |
github-actions
bot
added
the
Can Close?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 0768e1b.
In the original patch #2077,
tagandstamp_inputfields ofPushInfowere removed with the assumption that they become obsolete since bazel 5.0. However, bazel itself doesn't control our customizedPushInfoprovider. And we have been using them with bazel 5.3 with no issues.We have some downstream rules that are relying on these field and would like to keep using them in latest version of rules_docker.
@philsc for vis.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information