Respect runfiles of deps in cc_shared_library#673
Open
aszady wants to merge 1 commit intobazelbuild:mainfrom
Open
Respect runfiles of deps in cc_shared_library#673aszady wants to merge 1 commit intobazelbuild:mainfrom
deps in cc_shared_library#673aszady wants to merge 1 commit intobazelbuild:mainfrom
Conversation
aszady
force-pushed
the
cc_shared_library/runfiles
branch
from
c58176a to
4598cd4
Compare
One of the providers of `cc_shared_library` is `DefaultInfo`, so that one can use the produced library as a standalone artifact (without further consumption by CC rules). An example would be to just `dlopen` that from another program. For that to work, it needs to provide the complete runfiles as well, especially these needed by the (static) libraries it consists of. This change adds the missing collection of runfiles over `deps`.
aszady
force-pushed
the
cc_shared_library/runfiles
branch
from
4598cd4 to
3384272
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One of the providers of
cc_shared_libraryisDefaultInfo, so that one can use the produced library as a standalone artifact (without further consumption by CC rules). An example would be to justdlopenthat from another program. For that to work, it needs to provide the complete runfiles as well, especially these needed by the (static) libraries it consists of.This change adds the missing collection of runfiles over
deps.