Remove the false impresion that some bzl files are not public#539
Open
limdor wants to merge 1 commit intobazelbuild:mainfrom
Open
Remove the false impresion that some bzl files are not public#539limdor wants to merge 1 commit intobazelbuild:mainfrom
limdor wants to merge 1 commit intobazelbuild:mainfrom
Conversation
limdor
requested review from
armandomontanez,
c-mita,
comius,
hvadehra,
pzembrod and
trybka
as code owners
limdor
force-pushed
the
cleanup_visibility
branch
from
7342153 to
21d3f01
Compare
The value of INTERNAL_VISIBILIY variable was changed to public. However, the name of the variable seems to imply that it is not public. Removing it makes that clear.
limdor
force-pushed
the
cleanup_visibility
branch
from
21d3f01 to
cdb2b3e
Compare
Collaborator
|
@pzembrod is this something required internally at Google, or can we simplify this? If this is required, just let me know and we can leave a comment behind explaining the situation. |
armandomontanez
added
untriaged
Collaborator
|
I think we still want to have control of this internally; the external visibility was relaxed to allow rules_java to load stuff. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The value of INTERNAL_VISIBILIY variable was changed to public. However, the name of the variable seems to imply that it is not public. Removing it makes that clear.